Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[s] Fix Tutorials #5718

Merged
merged 3 commits into from
Feb 15, 2024
Merged

[s] Fix Tutorials #5718

merged 3 commits into from
Feb 15, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Feb 14, 2024 •
edited
Loading

About the pull request

This PR fixes several issues with tutorials:

  • Tutorial path was not guarded
  • Xenomorph tutorial allowed evolution/de-evolution. For evolution this just caused runtimes. De-evolution would ghostize you weirdly (couldn't get sent to lobby).
  • Ghosting when in a tutorial would throw a runtime because the observer Login would resume its call when a signal had already transferred the client to a newplayer mob.

Explain why it's good for the game

Less runtimes and ⭐ funkyness ⭐

e.g.

image
image

Testing Photographs and Procedure

Screenshots & Videos

image

Changelog

🆑 Drathek
fix: Fixed xeno tutorial allowing evolution/de-evolution
fix: Fixed some runtimes with tutorials
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Feb 14, 2024
@Drulikar Drulikar changed the title Fix Tutorials [s] Fix Tutorials Feb 14, 2024
cm13-github added a commit that referenced this pull request Feb 14, 2024
@cm13-github
TGS Test Merge (#5718)
de2f969
cm13-github added a commit that referenced this pull request Feb 14, 2024
@cm13-github
TGS Test Merge (#5718)
8ac5d64
Zonespace27
Zonespace27 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine

@Zonespace27 Zonespace27 added this pull request to the merge queue Feb 14, 2024
@Zonespace27 Zonespace27 removed this pull request from the merge queue due to a manual request Feb 14, 2024
cm13-github added a commit that referenced this pull request Feb 15, 2024
@cm13-github
TGS Test Merge (#5718)
12007fd
cm13-github added a commit that referenced this pull request Feb 15, 2024
@cm13-github
TGS Test Merge (#5718)
e1d29fc
@Birdtalon Birdtalon added this pull request to the merge queue Feb 15, 2024
Merged via the queue into cmss13-devs:master with commit 6d6f579 Feb 15, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Feb 15, 2024
@cm13-github
Automatic changelog for PR #5718 [ci skip]
3d2d93a
@Drulikar Drulikar deleted the Fix_Tutorials branch February 15, 2024 10:02
@Zonespace27 Zonespace27 added this to the Tutorials milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Birdtalon Birdtalon Birdtalon approved these changes

@Zonespace27 Zonespace27 Zonespace27 approved these changes

@harryob harryob harryob approved these changes

Assignees
No one assigned
Labels
Fix Fix one bug, make ten more
Projects
None yet
Milestone
Tutorials
Development

Successfully merging this pull request may close these issues.
4 participants
@Drulikar @Birdtalon @Zonespace27 @harryob