Fixes "Unbound" keybind slots sometimes not being removed #5720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes keybinds sometimes getting 'Unbound' slots permanently stuck to them.
This was caused by the
"clear_keybind"act code adding the keybind to the"Unbound"list for every key assigned to the keybind, rather than just once.(I can't really explain this very well but there's an example video below)
Explain why it's good for the game
It doesn't actually change the keybind's behaviour at all, but it's a bit weird to have an extra unremovable "Unbound" slot on some keybinds.
Testing Photographs and Procedure
Screenshots & Videos
Before:
TGBkF4aH6N.mp4
After:
oPBBrraydL.mp4
Changelog
🆑
fix: Fixed the 'Clear' button not resetting the number of keybind assignment slots. (Keybinds menu)
/:cl: