Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XM43E1 in regular gameplay #5724

Closed

Conversation

Releasethesea
Copy link
Contributor

@Releasethesea Releasethesea commented Feb 15, 2024

About the pull request

this pull request is an attempt to get the XM43E1 into normal gameplay as a side grade to the sniper, the XM43E1 is a sniper which main quirk is the ability to shoot through walls, i wanted to see it used in gameplay for a long while now since i fixxed it up previously, ive toned down the damage output greatly to be about the same as a normal sniper, compared to the normal sniper (M42A) it takes longer to kill aswell as more shots on some xenos a example of which is taking 1 aimed shot to kill a lesser drone with the M42 while the XM43 takes two. the rifle does very similar damage to the M42, the main feature of it being the ability to pierce xenos, which is why the damage is so similar

if i messed up anything in this PR PLEASE tell me and ill try to fix it, this is my first time making such a big project

Explain why it's good for the game

variety is good for gameplay i think so having the sniper be able to choose between the XM43 and the M42A would really help with keeping the gameplay cycle fresh

editing this due to forgetting to add some stuff! the rifle does low damage due to it having piercing! by this i mean it goes through xenos even when aimed shotting, which is also the reason behind it lacking night vision goggles

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

on mob of the armour
https://imgur.com/a/VJuPzsw

helmet not on mob
https://imgur.com/a/SHJvrNG

on mob helmet, due to it being animated im posting like this, i hope thats fine
https://imgur.com/a/BGx6CII

armour on floor/ in hand sprite
https://imgur.com/a/HNcOyym

tested included several rounds of shooting the xenos and counting the number of shots required to kill them, the normal sniper taking less time and rounds to kill than the XM43E1, wearing the armour in game, firing when not wearing armour and firing when wearing armour

Changelog

🆑
add: Adds the XM43E1 a optional sidegrade to snipers main rifle aswell as armour to go along with it
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Feb 15, 2024
@Releasethesea Releasethesea marked this pull request as draft February 16, 2024 20:56
@Releasethesea Releasethesea marked this pull request as ready for review February 16, 2024 21:51
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Feb 18, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github added Merge Conflict PR can't be merged because it touched too much code and removed Merge Conflict PR can't be merged because it touched too much code labels Feb 18, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Feb 20, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Feb 24, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Mar 31, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
@Drulikar Drulikar marked this pull request as draft April 4, 2024 00:35
cm13-github added a commit that referenced this pull request Apr 4, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Apr 6, 2024
@Drulikar
Copy link
Contributor

Drulikar commented Apr 6, 2024

Kaga's version of the rifle is merged. If you want to tweak that version further you'll need to resolve conflicts. But otherwise I recommend finding a niche with your armor as an additional option for the sniper to opt to use.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 14, 2024
@Drulikar Drulikar removed the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Apr 20, 2024
@Drulikar Drulikar closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Merge Conflict PR can't be merged because it touched too much code Needs Testing Need to test it on the guinea pigs (production server) Sprites Remove the soul from the game. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants