Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduces automatic research chemical contents property string #5738

Merged
merged 7 commits into from
Feb 26, 2024

Conversation

Megaddd
Copy link
Contributor

@Megaddd Megaddd commented Feb 17, 2024

About the pull request

Obfuscates automatic research chem suffix on health analyzers, for example, ACR1ATX1BNM5REG1BST10OMB5NGN1NTR1 to be just 7a, or any other two random characters instead.

Does not hide properties from showing on the research paper as they did before however.

Explain why it's good for the game

Cleans research chemicals with many properties from excessive text bloat on health analyzers

Non-corpsman grunts with a medical analyzer on the front should probably not be able to deduce all effects of a custom research chemical just based on its unique identifier. You can still ask your local corpsman or researcher. Or they may also simply label the containers appropriately.

Testing Photographs and Procedure

Screenshots & Videos

image
image
(Before this PR, this whole thing would show up in medical analyzer next to your chem name, ew)

Changelog

🆑
balance: health analyzer no longer shows large custom research chem property text rows.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Feb 17, 2024
@Megaddd
Copy link
Contributor Author

Megaddd commented Feb 17, 2024

Hacky one-line change, unsure how it would (or whether it even should) be pretty-coded. Feedback welcome.
Addressed.

@Megaddd Megaddd changed the title Scrambles automatic research chem suffix Reduces automatic research chemical contents property string Feb 19, 2024
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Feb 26, 2024
@Drulikar Drulikar added this pull request to the merge queue Feb 26, 2024
Merged via the queue into cmss13-devs:master with commit 0a04c89 Feb 26, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants