Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor stage three of black goo and added stage four. #5739

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Feb 17, 2024

About the pull request

Refactor black goo :
1- change how stage 3 was done because it was a mess. this stage function is to turn every infected into zombie.
2-add a stage 4 for when you zombie transformation is over.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
refactor: refactored stage three of black goo and added stage four.
/:cl:

Julien added 3 commits February 17, 2024 12:57
that turn stage three into a transitionary stage between human and zombie. not something you should stay on.
@github-actions github-actions bot added the Refactor Make the code harder to read label Feb 17, 2024
@Huffie56 Huffie56 marked this pull request as ready for review February 17, 2024 19:08
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft February 21, 2024 04:03
@Huffie56 Huffie56 marked this pull request as ready for review February 21, 2024 08:16
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 29, 2024
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
code/datums/diseases/black_goo.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar added this pull request to the merge queue Feb 29, 2024
Merged via the queue into cmss13-devs:master with commit 0deeaf6 Feb 29, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 29, 2024
@Huffie56 Huffie56 deleted the zombie_last_stage branch February 29, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Make the code harder to read Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants