Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor marine_armor.dm and split it into multiples files. #5740

Merged
merged 10 commits into from
Feb 24, 2024

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Feb 17, 2024

About the pull request

1-Refactor the marine_armor.dm file by splitting them into multiples files.
2-in marine_armor.dm i also remove a serie of duplicate declaration of the same items.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
refactor: refactor marine_armor.dm and split it into multiples files.
/:cl:

@github-actions github-actions bot added the Refactor Make the code harder to read label Feb 17, 2024
i think that's how it should be ordered? maybe...
@Huffie56 Huffie56 marked this pull request as ready for review February 17, 2024 18:59
code/modules/clothing/suits/marine_armor/_spe_fire.dm Outdated Show resolved Hide resolved
code/modules/clothing/suits/marine_armor/marine_armor.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft February 21, 2024 03:54
@Huffie56 Huffie56 marked this pull request as ready for review February 21, 2024 11:02
Copy link
Member

@SabreML SabreML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what Harry meant was to add an underscore to the name of the main 'parent' file (_marine_armor.dm), but have the rest be named normally. Like this:
image


Other than that though, looks good to me!

code/modules/clothing/suits/marine_armor/_ert.dm Outdated Show resolved Hide resolved
@Huffie56 Huffie56 marked this pull request as draft February 23, 2024 14:16
@Huffie56 Huffie56 marked this pull request as ready for review February 24, 2024 09:41
@SabreML SabreML added this pull request to the merge queue Feb 24, 2024
Merged via the queue into cmss13-devs:master with commit 747b74d Feb 24, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Feb 24, 2024
@Huffie56 Huffie56 deleted the marine_armor.dm branch February 24, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Make the code harder to read
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants