Gun action (and equip) buttons refactor #5750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed the `if("Reset Machine")` part rather than refactoring it because, as far as I can tell, nothing actually uses it.
harryob
requested changes
Feb 21, 2024
Co-Authored-By: harryob <[email protected]>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
added
the
Merge Conflict
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
harryob
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Refactors the 'gun action' buttons and the 'equip' button to have each have their own
/atom/movable/screensubtype, rather than all of their functionality being done throughif()checks in/atom/movable/screen/clicked().The 'gun action' buttons being these:
And the 'equip' button being this:
Explain why it's good for the game
Cleaner code, and the gun buttons now show their names in the status bar when hovered over thanks to this:
cmss13/code/modules/statusbar/statusbar.dm
Line 23 in 1bc0fa5
(That line has been there for a couple of years, but
/atom/movable/screen/gundidn't exist until now.)Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
refactor: Refactored the 'gun action' buttons, making them show their names in the status bar when hovered over.
/:cl: