Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Vampire Lurker Strain Damage Modifications #5753

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Feb 19, 2024

About the pull request

This PR corrects an erroneous change in apply_strain because only modifiers can be set here. The change to lower the damage tier would be undone when recalculate_damage would apply the lurker caste's values for the upper and lower damage values.

Ultimately I'm not certain it does need the damage reduction - but as of #5625 it does more with direct tail stabs so between the two this should be a minor nerf.

Explain why it's good for the game

Corrects an intended reduction in damage for taking the strain.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Drathek
balance: Corrected vampire lurker damage values (Effectively reduction by 5 damage for most attacks)
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Feb 19, 2024
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Feb 19, 2024
@Birdtalon Birdtalon added this pull request to the merge queue Feb 20, 2024
Merged via the queue into cmss13-devs:master with commit 8f0424e Feb 20, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Feb 20, 2024
@Drulikar Drulikar deleted the Fix_Erronous_Vamp_Change branch February 20, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants