Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map: Bigred change south lambda padlock and turned it into a checkpoint. #5763

Merged
merged 16 commits into from
Mar 31, 2024
Merged

Map: Bigred change south lambda padlock and turned it into a checkpoint. #5763

merged 16 commits into from
Mar 31, 2024

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Feb 20, 2024 •
edited
Loading

About the pull request

1-change south lambda padlock and turned it into a checkpoint.
2-refactored the code to remove unused areas and regroup all the lambda area at the same place.

Explain why it's good for the game

1-change to south padlock will unlock possibility for an easier push (this choke is very hard to push currently.)

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
refactor: refactored the lambda areas.
maptweak: turned south padlock into a checkpoint.
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Code Improvement Make the code longer Refactor Make the code harder to read labels Feb 20, 2024
@Huffie56 Huffie56 marked this pull request as ready for review February 20, 2024 16:06
@Huffie56 Huffie56 changed the title Map: Bigred change south lambda padlock and making it so that lambda as it's seperate elec network Map: Bigred change south lambda padlock and turned it into a checkpoint. Feb 20, 2024
@Huffie56 Huffie56 marked this pull request as draft February 20, 2024 20:06
@Huffie56 Huffie56 marked this pull request as ready for review February 21, 2024 12:29
@Huffie56 Huffie56 marked this pull request as draft February 21, 2024 12:30
@Huffie56 Huffie56 marked this pull request as ready for review February 21, 2024 13:55
@Huffie56 Huffie56 marked this pull request as draft February 21, 2024 17:06
@Huffie56 Huffie56 marked this pull request as ready for review February 22, 2024 19:11
@Huffie56 Huffie56 marked this pull request as draft February 22, 2024 21:39
@Huffie56 Huffie56 marked this pull request as ready for review February 24, 2024 08:38
Nanu308
Nanu308 requested changes Feb 25, 2024
View reviewed changes
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bilde
Move the Vehicle blockers a bit more west as showcased, also, will need to test it as its quite significant gameplay change when it comes to the flow of the map.

@Nanu308 Nanu308 marked this pull request as draft February 25, 2024 22:34
cm13-github added a commit that referenced this pull request Mar 26, 2024
@cm13-github
TGS Test Merge (#5763)
dc79160
@MistChristmas MistChristmas mentioned this pull request Mar 26, 2024
Closed
3 tasks
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Mar 26, 2024
@cuberound cuberound mentioned this pull request Mar 26, 2024
Open
3 tasks
cm13-github added a commit that referenced this pull request Mar 26, 2024
@cm13-github
TGS Test Merge (#5763)
71fb78a
cm13-github added a commit that referenced this pull request Mar 26, 2024
@cm13-github
TGS Test Merge (#5763)
4c4fb6f
cm13-github added a commit that referenced this pull request Mar 26, 2024
@cm13-github
TGS Test Merge (#5763)
42e0bac
cm13-github added a commit that referenced this pull request Mar 27, 2024
@cm13-github
TGS Test Merge (#5763)
49502e9
cm13-github added a commit that referenced this pull request Mar 27, 2024
@cm13-github
TGS Test Merge (#5763)
d62bd79
cm13-github added a commit that referenced this pull request Mar 27, 2024
@cm13-github
TGS Test Merge (#5763)
5b3ea52
@Drewzeedo5 Drewzeedo5 mentioned this pull request Mar 28, 2024
Closed
3 tasks
@Nanu308 Nanu308 added Mapping Approved adds 500 new dict keys and removed Testmerge Candidate we'll test this while you're asleep and the server has 10 players Needs Testing Need to test it on the guinea pigs (production server) labels Mar 28, 2024
Nanu308
Nanu308 approved these changes Mar 28, 2024
View reviewed changes
maps/map_files/BigRed/BigRed.dmm Outdated Show resolved Hide resolved
cm13-github added a commit that referenced this pull request Mar 28, 2024
@cm13-github
TGS Test Merge (#5763)
b4ee5e0
cm13-github added a commit that referenced this pull request Mar 29, 2024
@cm13-github
TGS Test Merge (#5763)
746bf27
cm13-github added a commit that referenced this pull request Mar 30, 2024
@cm13-github
TGS Test Merge (#5763)
d9d67d5
cm13-github added a commit that referenced this pull request Mar 30, 2024
@cm13-github
TGS Test Merge (#5763)
8ec14bf
cm13-github added a commit that referenced this pull request Mar 30, 2024
@cm13-github
TGS Test Merge (#5763)
3bc5025
cm13-github added a commit that referenced this pull request Mar 31, 2024
@cm13-github
TGS Test Merge (#5763)
01d01e0
@Huffie56 Huffie56 requested a review from Nanu308 March 31, 2024 10:11
SabreML
SabreML approved these changes Mar 31, 2024
View reviewed changes
code/game/area/BigRed.dm Outdated Show resolved Hide resolved
@SabreML SabreML enabled auto-merge March 31, 2024 13:54
@SabreML SabreML added this pull request to the merge queue Mar 31, 2024
Merged via the queue into cmss13-devs:master with commit b20c3bb Mar 31, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Mar 31, 2024
@cm13-github
Automatic changelog for PR #5763 [ci skip]
2e35e79
@Huffie56 Huffie56 deleted the bigred branch March 31, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SabreML SabreML SabreML approved these changes

@Nanu308 Nanu308 Awaiting requested review from Nanu308 Nanu308 is a code owner

Assignees
No one assigned
Labels
Code Improvement Make the code longer Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Refactor Make the code harder to read
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Huffie56 @cm13-github @SabreML @Nanu308 @Drulikar