Small auto-observe fixes #5788
Merged
Small auto-observe fixes #5788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes these runtime errors: runtime error: client_screen_add overridden. runtime error: client_screen_remove overridden.
github-actions
bot
added
Fix
Just to "move them over" so that I can put `COMSIG_MOB_LOGIN` a bit earlier.
Late-night coding never goes well so this is probably awful, but I'll look at it again in the morning.
harryob
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes/tweaks a couple of auto-observe things that I noticed after #5751.
Specifically:
Fixes
runtime error: client_screen_add overridden. Use override = TRUE to suppress this warning/runtime error: client_screen_remove overridden. Use override = TRUE to suppress this warning.This error was consistently thrown when a ghost who's body is being observed re-enters their body.
observe_target_new_mind()tries to re-register the some signals on the body's new client, but didn't have theoverrideargument set.Stops 'hidden' actions being added to the screen of observing players. (e.g. the xeno tacmap action if the queen isn't ovied)
Makes any observers transfer over to the new body when a xenomorph evolves/de-evolves.
(I also added
/mob/dead/observerto theobserversvariable's declaration since it wasn't particularly clear what the list held.)Fixes the target player's action buttons disappearing for observers if they reconnect or re-enter their body.
(The actions were being shown to the player in
Login()>show_hud()>update_action_buttons()before the observer could re-register signals inobserve_target_login().)In order to fix this I renamed the existing
COMSIG_GLOB_MOB_LOGIN,COMSIG_CLIENT_MOB_LOGIN,COMSIG_MOB_LOGINsignals, and madeCOMSIG_MOB_LOGINsend a bit earlier in the proc.Explain why it's good for the game
Bugfixes :)
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: Fixed 'hidden' action buttons being shown to observing players.
qol: Made any observers transfer over when a Xenomorph evolves/de-evolves.
/:cl: