Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Corpsening #5805

Merged
merged 8 commits into from
Mar 20, 2024
Merged

The Corpsening #5805

merged 8 commits into from
Mar 20, 2024

Conversation

BadAtThisGame302
Copy link
Contributor

@BadAtThisGame302 BadAtThisGame302 commented Feb 24, 2024

About the pull request

Heavily updates corpses and their clothes and items,

Explain why it's good for the game

Corpse code is REALLY REALLY Old, it was honestly kind of painful fixing it. (Two map_cold variants) 💀

Changelog

🆑
add: Heavily Updated Corpse Code.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Feb 24, 2024
Copy link
Contributor

github-actions bot commented Mar 3, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Mar 3, 2024
code/modules/gear_presets/corpses.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/corpses.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/corpses.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/corpses.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/corpses.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/corpses.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/corpses.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/corpses.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/corpses.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/corpses.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft March 3, 2024 14:21
@BadAtThisGame302 BadAtThisGame302 marked this pull request as ready for review March 3, 2024 19:13
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell this makes 100% of the corpses in distress signal no longer bursted.

I tried multiple times, and then compared with master. Only on master do I see bursted on shiva/lv624:
dead

The issue isn't with the create humans menu, those seem correct. Just that the landmarks used to spawn them I guess?
image

@Drulikar Drulikar marked this pull request as draft March 4, 2024 10:30
@SabreML SabreML removed the Stale beg a maintainer to review your PR label Mar 5, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Mar 13, 2024
@BadAtThisGame302 BadAtThisGame302 marked this pull request as ready for review March 18, 2024 18:41
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Mar 19, 2024
@Drulikar
Copy link
Contributor

This works but I'm not sure why we need to increase the quantity of actually bursted in the presets that don't mention bursted?

Now:
image

Before:
image

If its intentional then okay.

@Drulikar Drulikar added this pull request to the merge queue Mar 20, 2024
Merged via the queue into cmss13-devs:master with commit df999ac Mar 20, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Mar 20, 2024
@BadAtThisGame302 BadAtThisGame302 deleted the corpo branch March 20, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants