Fix bound math on mass screenshot verb #5814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SabreML
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR is a follow up to #5165 fixing the mass screenshot verb. See screenshots section below for comparison.
As far as I can tell the max x and max y is unchanged from before to now, so its just the concept of a min x and y that was handled incorrectly in how this verb was modified:
Before that PR:
cur_level.x_bounds: 175 cur_level.y_bounds: 226After that PR:
MAP_MAXX: 175 MAP_MINX: 1 MAP_MAXY: 226 MAP_MINY: 1Explain why it's good for the game
Bug fixes are good.
Testing Photographs and Procedure
Screenshots & Videos
Before this PR:
After this PR:
Changelog
🆑 Drathek
fix: Fixed the Mass Screenshot Debug verb bounds
/:cl: