Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M42 Spotter Sight now requires pamphlet. #5846

Closed

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Feb 29, 2024

About the pull request

As title.

Explain why it's good for the game

No more stealing the NVGs and not doing spotter stuff.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Spotter Sight is now locked to the pamphlet.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Feb 29, 2024
@Red-byte3D
Copy link
Contributor

Red-byte3D commented Feb 29, 2024

how is this going to interact with a perma dead sniper / spotter

what if the spotter permas? will he be able to get a new spotter?

what about looting gear from perma bodies, this will result in you not being able to use the sights if you loot it from a dead body

@Segrain
Copy link
Contributor

Segrain commented Feb 29, 2024

what if the spotter permas? will he be able to get a new spotter?

He already cannot now as is.

@realforest2001
Copy link
Member Author

realforest2001 commented Mar 1, 2024

The intention of the spotter kit is not to just give a free set of NVGs to marines to go frag with. And as Segrain stated, spotter is already irreplaceable.

@Tsurupeta
Copy link
Contributor

This does not fix the issue of people just stealing NVGs, as they can steal the spotter paper too, and in most cases, spotters dont do anything useful anyways besides being a battlebuddy. Real spotter can always ask for NVG back if he read the paper and his sight got stolen. Moreover, this makes spotter being unable to give his sight to someone else, even if spotter doesnt really see it needed for himself.

@morrowwolf
Copy link
Member

I'm going to write your "explain why it's good for the game" section for you as you couldn't be bothered to look past "muh admin" angle. Mark me as off topic please.

First, yeah it's easier since now admins don't have to hunt down someone who isn't marked as the spotter and is wearing the eyepiece after stealing it. It won't prevent just stealing it and running off as they can just like... also steal the pamphlet.

Second, I fully believe (and I'm pretty sure it's still this way unless things have gotten really dumb) that the more responsibility you take on the more fun stuff you should get to use in the game. Sergeants get neat kits and points for shit because they have responsibilities OOCly. Same with officers/COs/whatever else. This should further help enforce the requirement that you must be the spotter and take that responsibility if you want the fancy gear.

Third, night vision propagation and powercreep is a constant worry as DARKNESS IS A SERIOUS FACTOR OF THE GAMEPLAY. The distinction between marines and xenos with light and nightvision is there on purpose. The further you degrade this boundary the more you minimize the interesting parts of the game. Sure, it's one piece of gear but it's one piece of gear with zero downside or required further thought if looted.

Fourth is the "the game is interesting because you can powergame and do neat stuff" side. This is extremely important to actually consider. Yes, being rewarded for knowing the spotter usually has a powerful sight and grabbing it off perma folk is super cool. Getting that one chance in a few dozen games chance is neat. People should be rewarded for being smart in their gameplay. This is one of those rewards.

Fifth, RP-wise do you really need training on a sight like this? Probably not really. But RP/sim has been taking a backseat to gameplay and "rules changes" for years so fuck it I guess.

There's good and bad here. The good of this change, in my opinion, seems to outweigh the bad (as everyone knows I am a xeno main). Everyone will give different "weights" to the effects of this change. Just be chill bro.

P.S. if you really wanted to be a cool dude you'd make it so sniper spec could designate his spotter and redesignate it as an extension of his own training. This would give more "soft power" to the sniper as if he is still alive then the spotter gear is still potentially in play as well as handle the admin concerns that are the main target of this PR. (Also pamphlets are fucking gross stop using skill pamphlets.)

@realforest2001
Copy link
Member Author

Not going to mark you as off topic as I think addressing it the way you have is about as on-topic as you can get. You raised good points for both sides.

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than pamphlet, have it lock on equip, but sniper spec/command can unlock it (see /obj/item/storage/backpack/proc/toggle_lock)
That means that yes it can be looted, but that player can go seek out command or a sniper to use it. I don't think the command aspect will come into play much at all, but as far as sniper this reacquaints the sniper with their new spotter so they can work together.

@@ -70,6 +70,14 @@
name = "\improper M42 spotter sight"
desc = "A companion headset and night vision goggles system for USCM spotters. Allows highlighted imaging of surroundings. Click it to toggle."

/obj/item/clothing/glasses/night/m42_night_goggles/spotter/can_use_active_effect(mob/living/carbon/human/user)
if(!(GLOB.character_traits[/datum/character_trait/skills/spotter] in user.traits))
to_chat(user, SPAN_WARNING("You have no idea how to use this!"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message is unnecessary currently because the caller of this proc also sends a message.
image

@@ -70,6 +70,14 @@
name = "\improper M42 spotter sight"
desc = "A companion headset and night vision goggles system for USCM spotters. Allows highlighted imaging of surroundings. Click it to toggle."

/obj/item/clothing/glasses/night/m42_night_goggles/spotter/can_use_active_effect(mob/living/carbon/human/user)
if(!(GLOB.character_traits[/datum/character_trait/skills/spotter] in user.traits))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be exclusive to spotter. No reason why the spec can't also use it.

Comment on lines +77 to +79
else
return TRUE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
else
return TRUE
return ..()

Still ought to use the parent implementation of the proc ever it changes.

@Drulikar Drulikar marked this pull request as draft March 8, 2024 20:54
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Mar 16, 2024
@github-actions github-actions bot closed this Mar 23, 2024
@realforest2001 realforest2001 deleted the forest/spottersight branch March 29, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants