Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widescreen 2: The Electric Boogaloo #5861

Closed
wants to merge 30 commits into from

Conversation

567Turtle
Copy link
Contributor

@567Turtle 567Turtle commented Mar 1, 2024

About the pull request

All the features of Widescreen 1, but functional!

Explain why it's good for the game

Widescreen (and diagonal movement but that's another can of beans) are necessary features that most other codebases have already implemented. I'm a subscriber to the ideology that modernization of SS13 is a good thing, instead of staying stuck in the past.

I believe a change such as this will have very little effect to the balance of the game, as scopes and bug range has been changed accordingly. It WILL however make the game easier to get into for new players, as well as making the game just easier to look at overall as the screen will no longer be 50% text box.

Screenshots & Videos

prof

this is my minecraft skin btw what do you guys think
tuuefiing1

datumised view refactor courtesy of tgstation/TerraGov-Marine-Corps#6748

Changelog

🆑 TiviPlus, HarryOB, 567Turtle
add: Widescreen preference :)
/:cl:

@567Turtle 567Turtle requested a review from fira as a code owner March 1, 2024 22:21
@github-actions github-actions bot added the Feature Feature coder badge label Mar 1, 2024
@Nanu308 Nanu308 added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Mar 1, 2024
@koltoast

This comment was marked as off-topic.

@567Turtle

This comment was marked as off-topic.

@koltoast

This comment was marked as off-topic.

cm13-github added a commit that referenced this pull request Mar 6, 2024
cm13-github added a commit that referenced this pull request Mar 6, 2024
@Vicacrov
Copy link
Contributor

Vicacrov commented Mar 6, 2024

The "Hive Strengthening..." message is no longer centralised, not sure I should be reporting it here or as an issue report to be fixed later.

image

cm13-github added a commit that referenced this pull request Mar 6, 2024
cm13-github added a commit that referenced this pull request Mar 6, 2024
@harryob harryob added Testmerge Candidate we'll test this while you're asleep and the server has 10 players Needs Testing Need to test it on the guinea pigs (production server) labels Mar 6, 2024
cm13-github added a commit that referenced this pull request Mar 6, 2024
@Reisyns
Copy link

Reisyns commented Mar 6, 2024

Jarring as fuck to play with and the reasoning of it being so that 50% of your screen isn't taken up by a text box is invalid as you can just change the size of the right window at the same time as centring your screen more. Just because you want to modernize something doesn't mean it'll be a better change, some things don't need to be changed. But some people don't get that.

@sl0w3st
Copy link

sl0w3st commented Mar 6, 2024

Isn't text box very vital part of the game that you need to take your attention to?

Also, what about users with different monitor sizes?

cm13-github added a commit that referenced this pull request Mar 6, 2024
@Tsurupeta
Copy link
Contributor

If you have square monitor, the already small textbox will become even smaller.

@sl0w3st
Copy link

sl0w3st commented Mar 6, 2024

It looks like NVG users got free x2 scope and globber boiler has bigger risks when bombarding to east or west directions

@sl0w3st
Copy link

sl0w3st commented Mar 6, 2024

You can't point at things nor zoom your screen as observer

@sl0w3st
Copy link

sl0w3st commented Mar 6, 2024

GL spec and anyone wielding M79 got straight buffed with this thing

@GrrrKitten
Copy link
Contributor

Im crashing a lot from this when I use it with fullscreen mode. I have fullscreen mode enabled by default but I still have to unfullscreen and re-fullscreen pretty much everytime I get in. clearing cache and the usual crash fixers has not been helpful

@Mister-moon1
Copy link
Contributor

Issue regarding the viewport automatically resetting regardless of if you have it set to manual

@567Turtle
Copy link
Contributor Author

image

@567Turtle 567Turtle closed this Mar 6, 2024
@Staykeu

This comment was marked as off-topic.

@GrrrKitten
Copy link
Contributor

GrrrKitten commented Mar 6, 2024

it took me two rounds for it to feel pretty natural, I think the balance impacts of it would have even'd out over time. even though I am still not stold on widescreen for CM, I think this is giving up kinda early on the instant negative reaction that all PR's that change anything get.

Especially when things like dropoff can be adjusted.

(also if youre truly giving up on this pls let us get psuedo-widescreen via moving the hud to the right side/bottom of the viewport here xooxooxoxo
image)

@koltoast
Copy link

koltoast commented Mar 7, 2024

If you make it available only to observers it should be fine.

@Steelpoint
Copy link
Contributor

A shame, I liked it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Needs Testing Need to test it on the guinea pigs (production server) Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.