-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes pod cryo #5865
fixes pod cryo #5865
Conversation
I don't seem to be able to reproduce the issue locally on master. I assume I'm missing a step somewhere? |
so, currently the state of the pods only changes when evac is declared/cancelled. somehow, #5683 managed to launch without the pod state being updated by evac being declared, not entirely sure how. it's easily reproduced using the shuttle manipulator, though. this just makes sure the pod state is correctly updated to LAUNCHED, instead of being on READY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than this for the COMSIG_PARENT_QDELETING
handler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs destroy cleanup too of the list if the dock port is deleted
LGTM otherwise
Co-authored-by: SabreML <[email protected]>
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
fixes #5863
🆑
fix: you can now enter cryo on pods
fix: cryo pods no longer tell you that they're broken
/:cl: