Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes pod cryo #5865

Closed
wants to merge 3 commits into from
Closed

fixes pod cryo #5865

wants to merge 3 commits into from

Conversation

harryob
Copy link
Member

@harryob harryob commented Mar 2, 2024

fixes #5863

🆑
fix: you can now enter cryo on pods
fix: cryo pods no longer tell you that they're broken
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Mar 2, 2024
@SabreML
Copy link
Member

SabreML commented Mar 2, 2024

I don't seem to be able to reproduce the issue locally on master. I assume I'm missing a step somewhere?
I can see the "It does not appear to be working" message on examine, but climbing into the pod seems to work normally whether it's docked, crash-landing, or flying in space.

@harryob
Copy link
Member Author

harryob commented Mar 5, 2024

I don't seem to be able to reproduce the issue locally on master. I assume I'm missing a step somewhere? I can see the "It does not appear to be working" message on examine, but climbing into the pod seems to work normally whether it's docked, crash-landing, or flying in space.

so, currently the state of the pods only changes when evac is declared/cancelled. somehow, #5683 managed to launch without the pod state being updated by evac being declared, not entirely sure how. it's easily reproduced using the shuttle manipulator, though. this just makes sure the pod state is correctly updated to LAUNCHED, instead of being on READY

Copy link
Member

@SabreML SabreML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than this for the COMSIG_PARENT_QDELETING handler.

code/modules/shuttle/shuttles/crashable/escape_shuttle.dm Outdated Show resolved Hide resolved
Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs destroy cleanup too of the list if the dock port is deleted
LGTM otherwise

@Drulikar Drulikar marked this pull request as draft March 11, 2024 20:24
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Mar 19, 2024
@github-actions github-actions bot closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hypersleep/Cryopods on Escape Pods not working.
3 participants