Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Professor DUMMY to the CMO office, accessible by the CMO and the SEA #5874

Merged
merged 28 commits into from
Mar 5, 2024
Merged

Adds Professor DUMMY to the CMO office, accessible by the CMO and the SEA #5874

merged 28 commits into from
Mar 5, 2024

Conversation

Vicacrov
Copy link
Contributor

@Vicacrov Vicacrov commented Mar 3, 2024 •
edited
Loading

About the pull request

Adds a new wall cabinet to the CMO's office called the "professor dummy cabinet". It contains Professor DUMMY and its tablet: it is a tool for new nurses(!!) and doctors to learn medical treatment, including surgery.

The locker can only be opened by the CMO or the SEA (not even the CO can open it). It cannot be flashbanged, melted, or slashed.

There is a hefty warning for everyone when the dummy falls out, in case someone destroys the closet in a creative way:

image

The dummy and its tablet dust upon hijack impact, to avoid either side having a godmoded mob.

Explain why it's good for the game

It is a tool for new medical personnel to practice on. It can also ease boredom if the round is going too smoothly for marines.

Testing Photographs and Procedure

Setting up the tablet and hijacking. (The dummy no longer spawns in the Morgue but in the CMO office).

Screenshots & Videos
dreamseeker_AOKzqZswZy.mp4

Changelog

🆑
add: Added a professor dummy cabinet to the CMO office, containing Professor DUMMY and its control tablet. It is a tool to teach new medical personnel with. The cabinet is accessible by the CMO and the SEA only.
/:cl:

@Vicacrov Vicacrov requested a review from Nanu308 as a code owner March 3, 2024 22:23
@github-actions github-actions bot added Mapping did you remember to save in tgm format? Feature Feature coder badge labels Mar 3, 2024
@ihatethisengine
Copy link
Contributor

maybe just make it uninteractable on hijack?

@Vicacrov
Copy link
Contributor Author

Vicacrov commented Mar 3, 2024

maybe just make it uninteractable on hijack?

Dusting might be a bit jarring, but having a human-looking mob nobody can interact with would be more disruptive, I think.

Drulikar
Drulikar requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@Drulikar Drulikar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to instead be in the SEA vendor where its unhackable and otherwise then falls under the responsibility of the SEA that lent it to someone to use to put it away.

If you also want CMOs to access it, then they'd need a similar situation where only they (or a SEA) can vend it.

As of now, its the responsibility of the admin that spawned it to ensure it doesn't get misused.

@Drulikar Drulikar marked this pull request as draft March 4, 2024 04:57
@Vicacrov
Copy link
Contributor Author

Vicacrov commented Mar 4, 2024

Implemented changes:

  • Made a new subtype for this dummy as I realised the character setup one was the same.
  • Reverted the Morgue changes.
  • The dummy now dusts upon hijack impact, not upon hijack start (code bloat on my part).
  • Added a special closet to the CMO office, the "professor dummy cabinet".
    • It can be only opened with a CMO or SEA job, not access. (Not even a CO ID helps here.)
    • It cannot be flashbanged, slashed, or melted.
    • When the dummy falls out, everyone around the closet gets a warning how it should not be misused - this also covers the edge case where it gets destroyed by unconventional means. Ignorance is not an excuse when you get a red text this big.
    • The closet can store mobs but it fails to close if there is any other mob on its tile but the dummy. (No hiding in the indestructible closet.)

image

image

@Vicacrov Vicacrov marked this pull request as ready for review March 4, 2024 18:26
@Vicacrov Vicacrov changed the title Adds Professor DUMMY to the Morgue Adds Professor DUMMY to the CMO office, accessible by the CMO and the SEA Mar 4, 2024
Nanu308
Nanu308 approved these changes Mar 5, 2024
View reviewed changes
maps/map_files/USS_Almayer/USS_Almayer.dmm Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Mar 5, 2024
@Drulikar Drulikar marked this pull request as draft March 5, 2024 14:44
@Drulikar
Copy link
Contributor

Drulikar commented Mar 5, 2024

Feel free to undraft (Ready for review button near the bottom) when you're happy with it.

@Vicacrov Vicacrov marked this pull request as ready for review March 5, 2024 16:57
@Drulikar Drulikar added this pull request to the merge queue Mar 5, 2024
Merged via the queue into cmss13-devs:master with commit f3544c5 Mar 5, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Mar 5, 2024
@cm13-github
Automatic changelog for PR #5874 [ci skip]
3ac72a2
@Vicacrov Vicacrov deleted the professor_dummy_prespawned branch March 6, 2024 09:48
@Segrain Segrain mentioned this pull request Mar 15, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 17, 2024
@Segrain
Fixes for Professor Dummy. (#5951)
b7410dc 
# About the pull request

Followup to #5874.

# Explain why it's good for the game

`human/dummy` is designed to be noninteractive. It has godmode (not that
godmode does much), it is not processed (thus no bleeding, no
medicaments etc), it is not even added to medical HUD. Medical training
dummy should not be a subtype of it.
Also shuffled some code around so that, for example, somebody using a
dummy in thunderdome does not suddenly lose it on hijack.

# Changelog

:cl:
fix: Professor Dummy in CMO's office now works properly.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drulikar Drulikar Drulikar approved these changes

@Nanu308 Nanu308 Nanu308 approved these changes

Assignees
No one assigned
Labels
Feature Feature coder badge Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vicacrov @ihatethisengine @Drulikar @Nanu308