Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor : poddoor file and shutters file. #5886

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Mar 6, 2024

About the pull request

1-added a folder for poddoor and shutters.
2-move those files inside their folders.
3-extracting almayer and two tile children of poddoor and give them their own files.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
refactor: refactored poddoor file and shutters file.
/:cl:

@github-actions github-actions bot added the Refactor Make the code harder to read label Mar 6, 2024
@Huffie56 Huffie56 marked this pull request as ready for review March 7, 2024 19:15
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Mar 8, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Huffie56 Huffie56 marked this pull request as draft March 8, 2024 16:20
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Mar 9, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Huffie56
Copy link
Contributor Author

Huffie56 commented Mar 9, 2024

as far as i know conflict was due to #5892
so i implemented the fix into my change.

@Huffie56 Huffie56 marked this pull request as ready for review March 9, 2024 11:47
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Mar 17, 2024
Copy link
Member

@SabreML SabreML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! Just a couple of things.

code/game/machinery/doors/poddoor/poddoor.dm Outdated Show resolved Hide resolved
code/game/machinery/doors/poddoor/two_tile.dm Outdated Show resolved Hide resolved
@SabreML SabreML removed the Stale beg a maintainer to review your PR label Mar 18, 2024
@Huffie56 Huffie56 requested a review from SabreML March 20, 2024 10:51
@SabreML SabreML added this pull request to the merge queue Mar 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2024
@SabreML SabreML added this pull request to the merge queue Mar 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2024
@SabreML
Copy link
Member

SabreML commented Mar 20, 2024

🤔

Looks like there's server issues in a couple of the workflow steps. I'll try again a bit later.

@SabreML SabreML added this pull request to the merge queue Mar 20, 2024
Merged via the queue into cmss13-devs:master with commit 737213d Mar 20, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Mar 20, 2024
@Huffie56 Huffie56 deleted the shutter_blastdoor branch March 20, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Make the code harder to read
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants