Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light replacer speeds up colony light repair #5905

Merged
merged 11 commits into from
Mar 14, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Mar 9, 2024

About the pull request

This PR addresses several things:

  • Colony lights and their switch were capitalized so they were treated as proper nouns when examined
  • Colony lights don't actually use power, only their switch, so their power status text was incorrect
  • The light replacer can now be used to speed up the repair of colony lights by skipping 3 steps in the normal process
  • APC and SMES interfaces now properly close/disable when you are not adjacent to them or incapacitated
  • General refactoring of the colony_floodlights file to bring it closer to code standards

The APC and SMES UI fixes were just because I was very confused why they weren't behaving during testing, so I fixed them.

Explain why it's good for the game

I want to push power as a meaningful objective marines want to try to secure if possible. Currently colony lights are too tedious to repair and the light replacer is underused so I hope this can help rectify both problems somewhat.

Testing Photographs and Procedure

Screenshots & Videos

https://youtu.be/qJf1V-RdMok

Changelog

🆑 Drathek
balance: The light replacer can now be used to skip the crowbar, welding, and wire steps when repairing colony lights.
fix: Fixes SMES and APC interfaces not checking adjacency or incapacitated states
spellcheck: Fixed examine text for colony lights (improper names and not powered text)
/:cl:

@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Mar 9, 2024
@github-actions github-actions bot added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors labels Mar 9, 2024
code/game/machinery/colony_floodlights.dm Outdated Show resolved Hide resolved
code/game/machinery/colony_floodlights.dm Outdated Show resolved Hide resolved
code/game/machinery/colony_floodlights.dm Outdated Show resolved Hide resolved
code/game/machinery/colony_floodlights.dm Outdated Show resolved Hide resolved
code/game/machinery/colony_floodlights.dm Show resolved Hide resolved
code/game/machinery/colony_floodlights.dm Show resolved Hide resolved
@SabreML SabreML added this pull request to the merge queue Mar 14, 2024
Merged via the queue into cmss13-devs:master with commit 6b835c0 Mar 14, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Mar 14, 2024
@Drulikar Drulikar deleted the Light_Replacer_Buff branch March 14, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants