Ports stripping menu from TG #5914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm guessing this might fix that longstanding bug where the strip menu doesn't update sometimes? Thank you for this. |
|
This is nice - I think it looks like an improvement, I will review this tonight |
mullenpaul
previously requested changes
Mar 12, 2024
|
I'm away for a few days and then I have a few days leave in which I can burn time testing this. |
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Drulikar
previously requested changes
Mar 25, 2024
Drulikar
approved these changes
Apr 13, 2024
|
Sprites are existing sprites |
|
Two of paul's reviews are still outstanding. |
cm13-github
added a commit
that referenced
this pull request
Apr 13, 2024
3 tasks
cm13-github
added a commit
that referenced
this pull request
Apr 15, 2024
Drulikar
dismissed
mullenpaul’s stale review
Mostly resolved, though TGUI code likely needs refactoring in the future
cm13-github
added a commit
that referenced
this pull request
Apr 15, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
…lds (#6881) # About the pull request This PR is a followup to #6150 and #5914 that added new flags_item flags but not to the bitfields # Explain why it's good for the game Allows the VV to allow editing and displaying these flags correctly. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary>  </details> # Changelog :cl: Drathek code: Added missing bitfields for flags_item to VV /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
(This is a commissioned PR)
Ports tgstation/tgstation#57889 and adapts for our gameplay.
Explain why it's good for the game
Fancy and more convenient?
Testing Photographs and Procedure
str.mp4
Changelog
🆑 ihatethisengine2
add: ported stripping menu from TG
/:cl: