Fixes synthetics being in a weird limbo state when they have their head reattached. #5916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
requested changes
Mar 12, 2024
Co-authored-by: harryob <[email protected]>
Birdtalon
approved these changes
Mar 12, 2024
harryob
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Did some digging.
Turns out, when the Queen gibs someone the flag 'undefibbable' gets set.
Then, next time the Life() proc is called we get removed from the 'processable_humans_list' on SSHuman. (Makes sense, no reason to process someone unrevivable, which non-synth gibbed people are)
This means when the synth has their head reattached and they get revived they no longer process Life() ticks. This means their blindness + critical state will never get cleared.
I fixed this by not making synths 'undefibbable'. You already can't revive someone without a head, so you won't be able to revive a headless corpse.
In addition I checked the usages of 'undefibbable' and didn't find anything that would break from this not being set.
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Tested the following:
Not able to revive headless corpse
Not able to revive before head is fully attached
Revived synth can speak normally + see
Revived synth can walk and do normal actions when limbs are reattached.
Changelog
🆑
fix: Synths can now have their heads reattached without being sent to limbo-crit-hell.
/:cl: