Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small /client/MouseDrop() params fix #5928

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

SabreML
Copy link
Member

@SabreML SabreML commented Mar 12, 2024

About the pull request

Fixes /client/MouseDrop()'s parameters.
(See: https://www.byond.com/docs/ref/#/client/proc/MouseDrop)

Explain why it's good for the game

src_object was missing from the proc's parameters, so they were all off by one.
This didn't actually make a difference in-game since the SEND_SIGNAL() calls took that into account and params was never used, but obviously it'd be good if they were accurate.

Testing Photographs and Procedure

Screenshots & Videos

Before:
before args
After:
args after
(atoms were renamed of course)

Changelog

N/A

@SabreML SabreML added the Refactor Make the code harder to read label Mar 12, 2024
@Birdtalon Birdtalon added this pull request to the merge queue Mar 18, 2024
Merged via the queue into cmss13-devs:master with commit a3de7f8 Mar 18, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Make the code harder to read
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants