Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

you can now use the mortar during hijack if you are not a coward + custom shell warning for ghosts #5940

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

iloveloopers
Copy link
Contributor

@iloveloopers iloveloopers commented Mar 14, 2024

About the pull request

lets you deploy the mortar shipside.
lets you fire a shell on a shipside mortar during hijack but do not expect to live.

ghosts now get a warning when an OT shell is about to land. (I did not test this and I don't know how to, I just copy pasted from CAS fire missions)

Explain why it's good for the game

its funny and cool and soul

Testing Photographs and Procedure

Screenshots & Videos
2024-03-13.21-35-50.mp4
2024-03-13.21-27-03.mp4

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: You can now use the mortar while shipside during hijack, but only once.
add: Ghosts now get a warning when a custom mortar shell is about to land.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Mar 14, 2024
@HaultyAnonie
Copy link
Contributor

So we're just gonna ignore the restrictions of space.

@joaopslima
Copy link

So we're just gonna ignore the restrictions of space.

just aim the mortar horizontally

@Huffie56
Copy link
Contributor

Huffie56 commented Mar 14, 2024

considering mortar and cas work on fiorina station i don't see why not mortar and cas on almayer.
not sure why you limiting yourself to one shot and then it kill you?

@LeDoktor
Copy link

Not a contributor, but this is the kind of shit CM NEEDS if it's going to survive another month. SPEEDMERGE THIS RIGHT NOW!!!!

@iloveloopers
Copy link
Contributor Author

considering mortar and cas work on fiorina station i don't see why not mortar and cas on almayer. not sure why you limiting yourself to one shot and then it kill you?

Fiorina has glass ceilings, the shell wouldn't go through the almayer's metal ceiling

@iloveloopers iloveloopers changed the title you can now use the mortar during hijack if you are not a coward you can now use the mortar during hijack if you are not a coward + custom shell warning for ghosts Mar 17, 2024
@SabreML SabreML added the Feature Feature coder badge label Mar 23, 2024
code/modules/cm_marines/equipment/mortar/mortars.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/equipment/mortar/mortars.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/equipment/mortar/mortars.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/equipment/mortar/mortars.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/equipment/mortar/mortars.dm Outdated Show resolved Hide resolved
@Zonespace27 Zonespace27 added this pull request to the merge queue Mar 29, 2024
Merged via the queue into cmss13-devs:master with commit 052c09a Mar 29, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Mar 29, 2024
@ItsVyzo ItsVyzo mentioned this pull request Mar 30, 2024
@Segrain Segrain mentioned this pull request Mar 30, 2024
github-merge-queue bot pushed a commit that referenced this pull request Mar 31, 2024
# About the pull request

Followup to #5940.
I understand the newfashioned crusade against old singleletter
variables, but when engaging in it, can we please ensure that all the
renamed variables stay effectively the same with no wires crossed? Or at
least test our code?

# Explain why it's good for the game

Is fix.

# Changelog
:cl:
fix: Mortar works properly once again.
/:cl:
@iloveloopers iloveloopers deleted the mortar branch May 7, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants