Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds and updates various logs #5947

Merged
merged 11 commits into from
Mar 18, 2024
Merged

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Mar 15, 2024

About the pull request

This PR addresses several deficiencies with logging:

  • Punching xenos now is attack logged (attack file & attack_log var)
  • Flame projectiles (e.g. plasma sentry shots) now are attack logged (attack file & attack_log var)
  • Projectiles that hit mobs that don't do damage are now attack logged (attack file & attack_log var); not sure what this may actually apply to though
  • Logs citing the source as SOMETHING?? should now more likely indicate some atom that fired it
  • Projectile logs now indicate what it was fired from (usually either the gun, or the mob owner of a sentry)
  • Sentries now create niche logs when they are configured (IFF, ROF, renamed, powered on, powered off)
  • Reagent overdoses now retain their last_source_mob; this means death messages will indicate the last mob that contributed to an overdose in death messages to everyone
  • Tailstabbing attacks are now attack logged (attack file & attack_log var)
  • Devour and regurg is now interact logged
  • Unnesting is now interact logged + niche logged for a xeno
  • log_say now generally includes the area in the log
  • Niche logs now have a chat file option in TGChat
  • Temporary mute message/action attempts are now niche logged instead of say logged

Explain why it's good for the game

Should help with investigations greatly.

Testing Photographs and Procedure

Screenshots & Videos

image
image
image
image
niche

Changelog

🆑 Drathek
fix: Overdose death messages will now mention last mob that contributed to the OD
admin: Many additions to attack, say, interact, and niche logging
admin: Temporary muted messages/actions are now niche logged instead of say logged
ui: Added niche log filtering to TGChat (still requires admin niche logs preference)
/:cl:

@Drulikar Drulikar added the Logging Make the admins more miserable label Mar 15, 2024
@github-actions github-actions bot added UI deletes nanoui/html Fix Fix one bug, make ten more Admin Make things harder for admins labels Mar 15, 2024
Copy link
Contributor

@Birdtalon Birdtalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Birdtalon Birdtalon added this pull request to the merge queue Mar 18, 2024
Merged via the queue into cmss13-devs:master with commit a81a557 Mar 18, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Mar 18, 2024
@Drulikar Drulikar deleted the missing_logs branch March 18, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Make things harder for admins Fix Fix one bug, make ten more Logging Make the admins more miserable UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants