Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OT CAS rocket #5957

Closed
wants to merge 36 commits into from
Closed

OT CAS rocket #5957

wants to merge 36 commits into from

Conversation

iloveloopers
Copy link
Contributor

@iloveloopers iloveloopers commented Mar 16, 2024

About the pull request

adds AIM-224B-C 'Widowmaker Custom', basically an OT missile
works the same as other OT assemblies except you crowbar to remove items
doesn't require any skills to tinker with the rocket so that research can also possibly make something (cool smoke?)
does not require a detonator
does a small explosion (pathetic) if you leave it unlocked or without containers
costs 350 points
4 second travel time
direct bombard only
explosion location is telegraphed by a blinking dot for the entire travel time

Explain why it's good for the game

more CAS options are good
requires teamwork for maximum rocket efficiency so inter-department cooperation or whatever nanu likes to say
explosion limits up for debate

Testing Photographs and Procedure

2024-03-15.16-09-51.mp4

image

image

Changelog

🆑
add: new missile AIM-224B-C 'Widowmaker Custom' which allows for custom payload.
imageadd: added AIM-224B-C 'Widowmaker Custom' sprites.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Mar 16, 2024
@Segrain Segrain added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Mar 16, 2024
@Nanu308 Nanu308 added the Do Not Merge If you merge this PR, I will annihilate you label Mar 16, 2024
@Nanu308
Copy link
Member

Nanu308 commented Mar 16, 2024

I do not personally see a reason as to why we're re-adding what will basically be the fatty equilant.

That was really bad for xeno gameplay, and unfun to deal with due to the insane radius+explosive power and how much weeds/fortifications it could clear out.

@sleepynecrons
Copy link
Contributor

github has fallen millions will not merge

@Huffie56
Copy link
Contributor

thanks nanu for saving CM

@TheManWithNoHands
Copy link
Contributor

I do not personally see a reason as to why we're re-adding what will basically be the fatty equilant.

That was really bad for xeno gameplay, and unfun to deal with due to the insane radius+explosive power and how much weeds/fortifications it could clear out.

But it has the same limits as the OT mortar shell. So if that really where a problem, you need to remove that as well. Because this is, at its core, just another way to use the OT shell.

@iloveloopers iloveloopers reopened this Mar 16, 2024
@iloveloopers
Copy link
Contributor Author

2024-03-16.15-15-30.mp4

the missile landing location is now telegraphed by a blinking laze for the entire time that it takes to land

@iloveloopers
Copy link
Contributor Author

iloveloopers commented Mar 17, 2024

Its limited by CAS dropship fabricator points, 600 points for each missile + you still have to fill it with chems.

The reaction limits for missile are the same as the OT shell, if that is a problem, then why is the OT shell fine?

It will be just as or even more telegraphed than mortar with the blinking dot light as shown in the video above. It being the only missile that telegraphs its position in such a way will make known to xenos that the explosion WILL likely be larger than normal.

I tested it, you can outrun the instakill radius as a boiler in 2 seconds

It is direct bombard only, you cannot chain multiple of them in a fire mission. You can have multiple of them in the same dropship and fire one after the other, but so can the mortar.

As another commenter pointed out, this is essentially a reskin of the OT shell that requires dropship points instead of metal to make.

This is worth atleast a test merge.

@PhantomEpicness
Copy link
Contributor

I would be up for helping with setting up dynamic balancing based on explosive amount as I have mentioned before on discord should this not be able to be merged for balance reasons.

@GoldenDarkness55
Copy link
Contributor

This is just FATTY again except even better. At least cap the AoE significantly or make this an OB lol

@iloveloopers
Copy link
Contributor Author

iloveloopers commented Mar 28, 2024

base falloff increased to 150, meaning you can only get maximum effectiveness with custom research explosive chemicals

travel time decreased by 1 second (6 seconds total)

Copy link
Contributor

github-actions bot commented Apr 6, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 6, 2024
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Apr 6, 2024
@Nanu308 Nanu308 added Testmerge Candidate we'll test this while you're asleep and the server has 10 players Needs Testing Need to test it on the guinea pigs (production server) labels Apr 7, 2024
cm13-github added a commit that referenced this pull request Apr 7, 2024
cm13-github added a commit that referenced this pull request Apr 7, 2024
cm13-github added a commit that referenced this pull request May 20, 2024
cm13-github added a commit that referenced this pull request May 20, 2024
cm13-github added a commit that referenced this pull request May 21, 2024
cm13-github added a commit that referenced this pull request May 22, 2024
cm13-github added a commit that referenced this pull request May 22, 2024
cm13-github added a commit that referenced this pull request May 23, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label May 24, 2024
cm13-github added a commit that referenced this pull request May 25, 2024
cm13-github added a commit that referenced this pull request May 25, 2024
cm13-github added a commit that referenced this pull request May 27, 2024
cm13-github added a commit that referenced this pull request May 27, 2024
cm13-github added a commit that referenced this pull request May 27, 2024
@Skatuk Skatuk mentioned this pull request May 28, 2024
3 tasks
cm13-github added a commit that referenced this pull request May 28, 2024
cm13-github added a commit that referenced this pull request May 29, 2024
cm13-github added a commit that referenced this pull request May 29, 2024
cm13-github added a commit that referenced this pull request May 30, 2024
cm13-github added a commit that referenced this pull request May 30, 2024
cm13-github added a commit that referenced this pull request May 30, 2024
cm13-github added a commit that referenced this pull request May 30, 2024
cm13-github added a commit that referenced this pull request May 30, 2024
cm13-github added a commit that referenced this pull request May 30, 2024
@Drulikar
Copy link
Contributor

Closing until this can be in a state that Nanu feels their concerns for the DNM are resolved.

@Drulikar Drulikar closed this May 30, 2024
@Toastina
Copy link

i miss this test merge and so do 'many' people

@TheManWithNoHands
Copy link
Contributor

i miss this test merge and so do 'many' people

loopers is gone dude. This is gonna stay burryd unless someone picks it back up.

github-merge-queue bot pushed a commit that referenced this pull request Oct 26, 2024
# About the pull request

Stole code from #5957 to add a
proper warning dot.


# Explain why it's good for the game

Thermobaric is currently the only CAS direct fire missile that cannot be
dodged through the warning intended to make it possible because you
cannot clear the AoE before it pulls you back in. This fixes that.
Essentially the same kinda issue that caused the FATTY rocket to be
removed in the past. No warning = bad.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>



https://github.com/user-attachments/assets/a736acb2-9413-436e-932f-f908d881bee1



</details>


# Changelog
:cl:
add: Added a warning to thermobaric missile direct fire.
/:cl:

---------

Co-authored-by: harryob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Do Not Merge If you merge this PR, I will annihilate you Feature Feature coder badge Needs Testing Need to test it on the guinea pigs (production server) Sprites Remove the soul from the game. Stale beg a maintainer to review your PR Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.