Pilot Rework 2.0

[567Turtle]

About the pull request

Removes the Pilot Officer role. Replaces it with the Gunship Pilot and the Dropship Pilot. One mans the CAS ship, one mans the transport ship always. No more petty arguing.

Explain why it's good for the game

Currently with two pilot officers, the round goes one of two ways.

Either A, there's only one at round start and they get CAS.

Or B, there's two POs and they argue and bicker over who gets CAS. Eventually one of them gets CAS and the other one either cryo's or spends the next 2~ hours bored out of their mind.

Dropship PO is NOT fun. It just isn't. Anybody who says they have ever enjoyed dropship PO is a liar and a rube sent here by the CLF to spread lies and deceit AND they're paid off by the Rothschilds. The whole point of the second PO is to man the Alamo, but with how different CAS PO and Dropship PO are they might as well be two roles.

I really enjoy playing CAS, but the issue is every time I want to roll PO to do so I'm scared away by the thought that I'll get trapped playing dropship for the whole round instead of a marine roll. By separating the two roles like this, now whenever you role CAS pilot, if you get it, you will always get the experience which you want. If you roll Dropship pilot, you will always get the experience you want.

This PR will prevent the countless rounds wasted rolling PO, losing rock paper scissors, and cryoing, having to sit and wait for the next round to start to try again.

Screenshots & Videos

🐾🐾🐾🐾🐾🐾🐾🐾🐾

Changelog

🆑
add: PO has been split into two roles, the gunship pilot and the dropship pilot, no more arguing over who gets CAS.
/:cl:

[567Turtle]

I think this works but I wrote all of this in like 10 minutes so it probably doesnt, I tested it briefly and it worked.

[koltoast]

Alternate solution: instead of this PR just reduce the Dropship Pilot slots from two to one. That way if you roll it you can always do CAS. But then only one Auxiliary support personnel will have CAS skills, which might mean more CAS mishaps since there would be no more tutoring I suppose. I've never done CAS though so I wouldn't really know. It just looks difficult and intimidating to get into.

[567Turtle]

Alternate solution: instead of this PR just reduce the Dropship Pilot slots from two to one. That way if you roll it you can always do CAS. But then only one Auxiliary support personnel will have CAS skills, which might mean more CAS mishaps since there would be no more tutoring I suppose. I've never done CAS though so I wouldn't really know. It just looks difficult and intimidating to get into.

This was the original intention but then I didn't want to do that.

[Drulikar]

Previous issues with the landmarks are still unresolved.

Both spawn here like this (fallback position - with wrong squad icon)


Also role preference page is very wonky:

[567Turtle]

pr done i think :)

[Nanu308]

mapping lgtm

[Nanu308]

mapping seems fine

[567Turtle]

done :)

[Drulikar]

Undrafting because I assume you mean for it to be undrafted (use the Ready for review button). Will let Harry be the one to merge since you wanted to do it the database migration way for hours.

[ondrej008]

Is it intentional that playtime isn't shared between the two (three) roles?

[567Turtle]

Is it intentional that playtime isn't shared between the two (three) roles?

It can be considered an oversight but as no roles are dependant on either POs playtime it's not really an issue I don't think. Plus, I believe the twos jobs are different enough to warrant seperate playtimes.

[harryob]

Is it intentional that playtime isn't shared between the two (three) roles?

literally nothing to do with the pr, just how i chose to do the db migration