Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pizza Time Galaxy Version #5963

Closed

Conversation

Nanu308
Copy link
Member

@Nanu308 Nanu308 commented Mar 17, 2024

About the pull request

Mapping good, mapping awesome
Sprites by Wei aka Esselnek, Mapping by Nanu, Reviewed by Spartanbobby map wise

Explain why it's good for the game

Better and more awesome

Testing Photographs and Procedure

Screenshots & Videos

awesesomepizza

Changelog

🆑 Nanu308, Sleepynecrons
imageadd: Added new sprites for diner things such as new sofas, stool, walls, floors, tables etc. which are made by Wei aka Sleepynecrons.
maptweak: Re-did parts of the Pizza ERT base for better aesthetic looks. Done by Nanu, reviewed by Spartanbobby.
/:cl:

Sprites by Wei aka Esselnek, Mapping by Nanu, Reviewed by Spartanbobby
@Nanu308 Nanu308 marked this pull request as draft March 17, 2024 08:19
@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? labels Mar 17, 2024
Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stop ignoring my DMs and fix the sprites

@spartanbobby
Copy link
Contributor

Sprites look good, LGTM

@Nanu308
Copy link
Member Author

Nanu308 commented Mar 17, 2024

stop ignoring my DMs and fix the sprites

I require tailored instructions ehrm kiss the ring first

Added doors, handrail fixes, direction fixes, more layer fixes
@Nanu308 Nanu308 marked this pull request as ready for review March 17, 2024 20:18
@Nanu308
Copy link
Member Author

Nanu308 commented Mar 17, 2024

stop ignoring my DMs and fix the sprites

sorted :3

@sleepynecrons
Copy link
Contributor

stop ignoring my DMs and fix the sprites

sorted :3

requires a review from almighty sammy

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T style dividers are layered weirdly if you have a tall sprite.
Water coolers are layered under dividers.
(Just saw it now) Bottles just below the water cooler mentioned are clipped under the table too.
Minor: Empty plating under windows
image

Double wide airlocks animate weirdly:
doors

@Drulikar
Copy link
Contributor

Also I dunno if this is intentional, did you mean to use the couch and stool subtypes that have no buckling implemented?

@Drulikar Drulikar marked this pull request as draft March 18, 2024 05:17
Layer Fixes and Door Fixes
@Nanu308 Nanu308 marked this pull request as ready for review March 18, 2024 13:34
@Nanu308
Copy link
Member Author

Nanu308 commented Mar 18, 2024

Also I dunno if this is intentional, did you mean to use the couch and stool subtypes that have no buckling implemented?

stools i could do, but couches not so much, will need some help coding and dealing with the layer for those due to the sprite hides most of people, and idk how to make a structure have two buckle points with two offsets for both unless i split the sprite in two and make it two structures

@Drulikar
Copy link
Contributor

Coolers are still layered weird, airlocks are unchanged, in general most layering is worse now than before for the dividers.

@Drulikar Drulikar marked this pull request as draft March 19, 2024 06:11
Fixes doors weird animation 2.0
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Mar 24, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented Apr 1, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 1, 2024
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sproites

@nauticall nauticall added the Sprites Approved confirmed no stray pixels label Apr 6, 2024
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Apr 7, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 15, 2024
@github-actions github-actions bot closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping did you remember to save in tgm format? Merge Conflict PR can't be merged because it touched too much code Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants