Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A more breakable Kutjevo #5974

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

spartanbobby
Copy link
Contributor

@spartanbobby spartanbobby commented Mar 18, 2024

About the pull request

This PR removes a fair amount (but not all) of the colony building hull wall from Kutjevo along with some hull windows and makes some objects on the ground that looked passible but weren't not look passible

Explain why it's good for the game

The map before has a ton of colony walls next to colony unbreakable walls, it's annoying, confusing, and seemingly random, due to the changes in this PR the map should now have more areas to flank/fight in at your own risk

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑SpartanBobby
maptweak: Changes to hullwall placment on Kutjevo this PR should allow you to break open much more of the colony buildings aswell as get into new areas to flank and play around
/:cl:

@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Mar 18, 2024
@Nanu308 Nanu308 added Testmerge Candidate we'll test this while you're asleep and the server has 10 players Needs Testing Need to test it on the guinea pigs (production server) labels Mar 18, 2024
cm13-github added a commit that referenced this pull request Mar 19, 2024
cm13-github added a commit that referenced this pull request Mar 21, 2024
cm13-github added a commit that referenced this pull request Mar 21, 2024
cm13-github added a commit that referenced this pull request Mar 22, 2024
cm13-github added a commit that referenced this pull request Mar 23, 2024
cm13-github added a commit that referenced this pull request Mar 26, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Mar 26, 2024
cm13-github added a commit that referenced this pull request Mar 26, 2024
cm13-github added a commit that referenced this pull request Mar 26, 2024
@cuberound cuberound mentioned this pull request Mar 26, 2024
3 tasks
cm13-github added a commit that referenced this pull request Mar 26, 2024
cm13-github added a commit that referenced this pull request Mar 26, 2024
cm13-github added a commit that referenced this pull request Mar 26, 2024
cm13-github added a commit that referenced this pull request Mar 27, 2024
cm13-github added a commit that referenced this pull request Mar 27, 2024
cm13-github added a commit that referenced this pull request Mar 27, 2024
@harryob harryob removed the Stale beg a maintainer to review your PR label Mar 28, 2024
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been in testing and heard good comments as well as seen some good stuff.

lgtm approved

@Nanu308 Nanu308 added Mapping Approved adds 500 new dict keys and removed Testmerge Candidate we'll test this while you're asleep and the server has 10 players labels Mar 28, 2024
@Nanu308 Nanu308 removed the Needs Testing Need to test it on the guinea pigs (production server) label Mar 28, 2024
@Nanu308 Nanu308 added this pull request to the merge queue Mar 28, 2024
Merged via the queue into cmss13-devs:master with commit 701d7cc Mar 28, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants