Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LV-624 - Nightmare Insert] Command Dome #5988

Closed
wants to merge 5 commits into from

Conversation

Steelpoint
Copy link
Contributor

@Steelpoint Steelpoint commented Mar 20, 2024

About the pull request

This PR adds a new nightmare insert of the gym that can transform it into a 'Command Dome', the structure contains amenities expected of a command area, however it is also a new possible spawn location for a comms array.

It uses the number 1 comms spawn, meaning it shares the spawn location with the Engineering comms spawn. Ergo there is a 50/50 the 1 comms spawns either in south Engineering, or central Command.

This also adds a rarer alt spawn for the Command Dome that spawns it as a heavily fortified, but breached, area that some survivors used.

Explain why it's good for the game

The addition of a second possible colony spawn for a comms array would help make the central colony an actually desirable location to hold and fortify for both sides, and make the colony a possible combat zone.

As it stands, the central colony is rarely a fought over area as both sides normally use it as a transit zone from the FOB to the cave frontline, and any major fighting is usually contained towards the west/east rivers or Engineering, ergo Marines never really fortify the central colony thus it becomes a backline area.

This change would have a chance that both sides now have to fight over the centre of the colony. Thus breathing new life into this area of the map that is so often bypassed.

Testing Photographs and Procedure

Screenshots & Videos

Main Spawn
Screenshot 2024-03-20 16 21 54

Uncommon Alt Spawn
Screenshot 2024-03-20 16 17 14

Changelog

🆑
mapadd: A new 'Command Dome' nightmare insert has been added to LV-624. Having a chance to appear in place of the Gym.
/:cl:

@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Mar 20, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Mar 28, 2024
@Nanu308 Nanu308 marked this pull request as draft March 28, 2024 12:06
@Nanu308 Nanu308 removed the Stale beg a maintainer to review your PR label Mar 28, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Mar 30, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Apr 6, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Steelpoint
Copy link
Contributor Author

Assuming nothing breaks I'll re-work the PR in <~1week

@Steelpoint Steelpoint changed the title [LV-624] Command Dome - New Comms Array Location [LV-624 - Nightmare Insert] Command Dome Apr 10, 2024
@Steelpoint Steelpoint marked this pull request as ready for review April 10, 2024 10:33
@Steelpoint
Copy link
Contributor Author

I've updated this to be a nightmare insert that has a chance to replace the Gym with a Command Dome.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 19, 2024
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Apr 24, 2024
@Nanu308
Copy link
Member

Nanu308 commented May 1, 2024

I am back from being dead.

After some further considerations I think the command insert would fit better into the Tcomms location on LV. Having a tcomms so close to Hydro i dont think is a good thing due to how frequent Marines entrench or go to hold Hydro.

Due to that I'd like to see if as a tcomms variant instead 👍

@Nanu308 Nanu308 marked this pull request as draft May 1, 2024 16:48
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label May 1, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented May 9, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label May 9, 2024
@Steelpoint
Copy link
Contributor Author

Will finish this when I have free time to fix mapping issues and make requested changes

@Steelpoint Steelpoint closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping did you remember to save in tgm format? Merge Conflict PR can't be merged because it touched too much code Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants