Tacmap makes no update noise for observers when hear/silence ghost announcement is toggled on #5990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Segrain
requested changes
Mar 21, 2024
Co-authored-by: Segrain <[email protected]>
Segrain
approved these changes
Mar 21, 2024
Birdtalon
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This is a follow-up to #5895 that mutes announcement sounds with a new preference option.
Tacmaps use a different proc that I missed the first time, this PR mutes them too.
Explain why it's good for the game
Same as in #5895, if someone just wants to be online but not get jumpscared by random noises (e.g. staff or people waiting for larva/ERT), this helps them.
Testing Photographs and Procedure
Changelog
🆑
add: Tacmap announcements are now also muted if you have hear/silence ghost announcements toggled on.
/:cl: