Fixes indefinite stasis bug #5996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SabreML
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes #5960, The knockdown status effect was applying a floored trait to the user on every tick through the handle_stasis_bag proc, and the interrupt_all flags was being passed into the do_after which meant that it wouldn't be possible to execute the action. This is because every time the user clicked the resist verb the interrupt_knocked_down (part of interrupt_all) flag in conjunction with the floored trait would always return false.
To solve this I instead passed in the interrupt_unconscious flag, meaning the other conditions would allow the user to resist out of the bag, we could instead just apply a Root (immobilize status effect) to the handle_stasis_bag proc and pass in the interrupt_all flag into the do_after as it was before. The only difference being when the user exits the bag they will be standing up instead of lying down, and all other interrupts will cause the action to cancel. (KnockDown applies both a floored and immobilize trait, Root just applies the immobilize trait). Or we can just modify the bitflags and pass in a custom one without the knocked down flag.
Changelog
🆑
fix: fixes users not being able to resist out of the stasis bags
/:cl: