Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes indefinite stasis bug #5996

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Fixes indefinite stasis bug #5996

merged 1 commit into from
Mar 26, 2024

Conversation

vero5123
Copy link
Contributor

@vero5123 vero5123 commented Mar 24, 2024

About the pull request

Fixes #5960, The knockdown status effect was applying a floored trait to the user on every tick through the handle_stasis_bag proc, and the interrupt_all flags was being passed into the do_after which meant that it wouldn't be possible to execute the action. This is because every time the user clicked the resist verb the interrupt_knocked_down (part of interrupt_all) flag in conjunction with the floored trait would always return false.

To solve this I instead passed in the interrupt_unconscious flag, meaning the other conditions would allow the user to resist out of the bag, we could instead just apply a Root (immobilize status effect) to the handle_stasis_bag proc and pass in the interrupt_all flag into the do_after as it was before. The only difference being when the user exits the bag they will be standing up instead of lying down, and all other interrupts will cause the action to cancel. (KnockDown applies both a floored and immobilize trait, Root just applies the immobilize trait). Or we can just modify the bitflags and pass in a custom one without the knocked down flag.

Changelog

🆑
fix: fixes users not being able to resist out of the stasis bags
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Mar 24, 2024
@SabreML SabreML added this pull request to the merge queue Mar 26, 2024
Merged via the queue into cmss13-devs:master with commit 94f27f7 Mar 26, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't resist out of stasis bags.
2 participants