-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preferences for a darker crit overlay and a black flash overlay #5997
Preferences for a darker crit overlay and a black flash overlay #5997
Conversation
Co-authored-by: Zonespace <[email protected]>
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For real this time
About the pull request
Now these overlays have less of a shock factor for accessibility. The reasoning for also a preference for crit is because when being revived you might still be deep in crit which can also be a flashbang. These could be combined into one preference, but I feel it didn't hurt to keep them separate so they're more obvious what they affect.
See photographs below.
Explain why it's good for the game
It was requested that there be a preference to lessen the flash effect for people that are photosensitive.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 Drathek
add: Added preference for a darker crit overlay and black flash overlay
/:cl: