Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences for a darker crit overlay and a black flash overlay #5997

Merged

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Mar 24, 2024

About the pull request

Now these overlays have less of a shock factor for accessibility. The reasoning for also a preference for crit is because when being revived you might still be deep in crit which can also be a flashbang. These could be combined into one preference, but I feel it didn't hurt to keep them separate so they're more obvious what they affect.

  • For dark crit preference, it is the original overlay but colored gray so lessen its brightness.
  • For dark flash preference, the screen will turn black instead of white.

See photographs below.

Explain why it's good for the game

It was requested that there be a preference to lessen the flash effect for people that are photosensitive.

Testing Photographs and Procedure

Screenshots & Videos

image

normal
dark

flash_normal
flash_dark

Changelog

🆑 Drathek
add: Added preference for a darker crit overlay and black flash overlay
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Mar 24, 2024
code/modules/client/preferences_toggles.dm Outdated Show resolved Hide resolved
code/modules/client/preferences_toggles.dm Outdated Show resolved Hide resolved
code/modules/client/preferences_toggles.dm Show resolved Hide resolved
code/modules/mob/living/living.dm Show resolved Hide resolved
@Zonespace27 Zonespace27 marked this pull request as draft March 29, 2024 20:34
@Drulikar Drulikar marked this pull request as ready for review March 30, 2024 02:22
Copy link
Contributor

github-actions bot commented Apr 7, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 7, 2024
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Apr 7, 2024
@SabreML SabreML dismissed Zonespace27’s stale review April 9, 2024 09:12

Requested changes implemented

Copy link
Member

@SabreML SabreML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For real this time

@SabreML SabreML added this pull request to the merge queue Apr 9, 2024
Merged via the queue into cmss13-devs:master with commit ac92228 Apr 9, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Apr 9, 2024
@Drulikar Drulikar deleted the Darkened_Crit_Flash_Preferences branch April 10, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants