Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Kutjevo caves OBable, fixes northeast/southeast caves being switched up, changes awful path names #6000

Closed
wants to merge 1 commit into from

Conversation

Vicacrov
Copy link
Contributor

@Vicacrov Vicacrov commented Mar 24, 2024

About the pull request

Does three things:

  1. Makes all caves OBable, but not CAS-able. See before-after:
Screenshots
  • yellow can be CAS'd/OB'd
  • blue can be OB'd but not CAS'd
  • red cannot be CAS'd or OB'd

Before:

image

After:

image

  1. Fixes Northeast and Southeast caves being switched up
Screenshots

The red circle was called South East Caves, the blue circle was called North East Caves.

image

  1. Fixes the weird snake+camelcase path naming

Explain why it's good for the game

Every other map (edit: except for Trijent) removed deep underground caves as it is the hive core's job to keep the area un-OBable, Kutjevo was somehow behind on this.

Testing Photographs and Procedure

See above.

Changelog

🆑
maptweak: Fixed Kutjevo Northeast Caves being called Southeast Caves and Southeast Caves being called Northeast Caves.
maptweak: Kutjevo's North, Northeast, Southeast, and South Caves, and the South Colony Treatment Plant areas can be now OB'd (but not CAS'd), bringing these cave areas up to standard.
/:cl:

@Vicacrov Vicacrov requested a review from Nanu308 as a code owner March 24, 2024 13:46
@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Mar 24, 2024
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needs some live testing tho

@Nanu308 Nanu308 added Mapping Approved adds 500 new dict keys Do Not Merge If you merge this PR, I will annihilate you Testmerge Candidate we'll test this while you're asleep and the server has 10 players Needs Testing Need to test it on the guinea pigs (production server) labels Mar 28, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Mar 28, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Drulikar Drulikar marked this pull request as draft April 3, 2024 02:56
@Vicacrov
Copy link
Contributor Author

Vicacrov commented Apr 5, 2024

someone is free to adopt this, I'm unfortunately not in the headspace to do development atm

@Vicacrov Vicacrov closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge If you merge this PR, I will annihilate you Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Merge Conflict PR can't be merged because it touched too much code Needs Testing Need to test it on the guinea pigs (production server) Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants