Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flames remove snow ! #6001

Merged
merged 10 commits into from
Apr 7, 2024
Merged

flames remove snow ! #6001

merged 10 commits into from
Apr 7, 2024

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Mar 24, 2024

About the pull request

makes snow scortchable and implements behavior for it ( thank you kugamo for making the LV grass scortchable so that the basework for it exists). intensity numbers might need tweeking if maintainers feel like it, but other than that it works.

Explain why it's good for the game

removing snow is pain in ass and even more so for marines, explosions can already remove snow and it only makes sance for flames to melt the snow. only bluefire can remove the deapest snow in one use, green and red flames remove abut two layers

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: flames melt the snow
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Mar 24, 2024
code/game/turfs/snow.dm Outdated Show resolved Hide resolved
code/game/turfs/snow.dm Outdated Show resolved Hide resolved
code/game/turfs/snow.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft April 3, 2024 02:31
@cuberound cuberound marked this pull request as ready for review April 3, 2024 07:39
code/game/turfs/auto_turf.dm Outdated Show resolved Hide resolved
code/game/turfs/auto_turf.dm Outdated Show resolved Hide resolved
code/game/turfs/snow.dm Outdated Show resolved Hide resolved
code/game/turfs/snow.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Apr 6, 2024
@Drulikar Drulikar marked this pull request as draft April 6, 2024 09:29
@cuberound cuberound marked this pull request as ready for review April 6, 2024 10:40
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Though I will note it may make sense if adjacent snow tiles melted a layer too - but it doesn't have to. Also the scorch seems to only happen once so if its a deep enough patch of snow and a low enough flame, you'll still have snow remain despite fire continuing to burn on it for a while.

@Drulikar Drulikar added this pull request to the merge queue Apr 7, 2024
Merged via the queue into cmss13-devs:master with commit e95d34a Apr 7, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants