Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster snow removal for bigger xenomorphs #6002

Merged
merged 7 commits into from
Apr 6, 2024

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Mar 24, 2024

About the pull request

makes the snow removal dependant of xenomorph size, making it 1,5 ( lesser) to 4 times (big xenos) faster ( still takes a while even for the largest xenos to remove deap snow)

Explain why it's good for the game

removing snow is painful job that makes maps with snow unwanted, huge xenomorphs should not have that hard time showeling some snow out of their way, makes it fair with the flames removing snow PR

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: greatly decreses snow removal time, now it depends on xenomorph size
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Mar 24, 2024
Copy link
Contributor

github-actions bot commented Apr 1, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 1, 2024
Copy link
Member

@SabreML SabreML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like /turf/open/snow isn't actually used anywhere other than a nightmare variant of CORSAT. Everything else uses /turf/open/auto_turf/snow, so this needs to be added to that as well.
(I don't know why we have two mostly identical versions of a snow turf)

@SabreML SabreML removed the Stale beg a maintainer to review your PR label Apr 2, 2024
@Drulikar Drulikar marked this pull request as draft April 3, 2024 02:30
@cuberound cuberound marked this pull request as ready for review April 3, 2024 07:18
Copy link
Member

@SabreML SabreML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I was wondering if the time should be changed from 12 to 18 so that it's unchanged for lesser drones (they now have a time of 8 due to a mob size of MOB_SIZE_XENO_VERY_SMALL), but I don't think it's that much of an issue.
IMO it can just be changed later on if it seems too fast.

@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Apr 6, 2024
@Drulikar Drulikar added this pull request to the merge queue Apr 6, 2024
Merged via the queue into cmss13-devs:master with commit 9b9ab1f Apr 6, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Apr 6, 2024
@RavinHobo
Copy link

crusher snow plough variant when?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants