-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster snow removal for bigger xenomorphs #6002
Conversation
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like /turf/open/snow
isn't actually used anywhere other than a nightmare variant of CORSAT. Everything else uses /turf/open/auto_turf/snow
, so this needs to be added to that as well.
(I don't know why we have two mostly identical versions of a snow turf)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I was wondering if the time should be changed from 12
to 18
so that it's unchanged for lesser drones (they now have a time of 8
due to a mob size of MOB_SIZE_XENO_VERY_SMALL
), but I don't think it's that much of an issue.
IMO it can just be changed later on if it seems too fast.
crusher snow plough variant when? |
About the pull request
makes the snow removal dependant of xenomorph size, making it 1,5 ( lesser) to 4 times (big xenos) faster ( still takes a while even for the largest xenos to remove deap snow)
Explain why it's good for the game
removing snow is painful job that makes maps with snow unwanted, huge xenomorphs should not have that hard time showeling some snow out of their way, makes it fair with the flames removing snow PR
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
balance: greatly decreses snow removal time, now it depends on xenomorph size
/:cl: