Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes armor light staying on after removal #6004

Merged
merged 4 commits into from
Apr 6, 2024
Merged

Fixes armor light staying on after removal #6004

merged 4 commits into from
Apr 6, 2024

Conversation

vero5123
Copy link
Contributor

@vero5123 vero5123 commented Mar 24, 2024

About the pull request

Fixes #5672 , just put a conditional to check if the armor contains a light source that is currently turned on, if so we just turn it off when the user removes it from their inventory.

Changelog

🆑
fix: Fixes armor light staying on after removal.

@Superwelder
Copy link

Many thanks for looking at my issue!

@SabreML SabreML added the Fix Fix one bug, make ten more label Mar 26, 2024
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use explicit src

code/game/objects/items.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft March 27, 2024 14:36
@vero5123 vero5123 marked this pull request as ready for review March 27, 2024 19:15
@vero5123 vero5123 requested a review from harryob April 1, 2024 18:07
@vero5123
Copy link
Contributor Author

vero5123 commented Apr 6, 2024

Many thanks for looking at my issue!

Np

@harryob harryob added this pull request to the merge queue Apr 6, 2024
Merged via the queue into cmss13-devs:master with commit 5cadb4a Apr 6, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Armor Light Not Turning Off
4 participants