Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metal rods take up less space now (from medium to small) #6007

Closed
wants to merge 1 commit into from
Closed

Metal rods take up less space now (from medium to small) #6007

wants to merge 1 commit into from

Conversation

QuickLode
Copy link
Contributor

@QuickLode QuickLode commented Mar 25, 2024

About the pull request

This PR changes metal rods and plasteel rods from occupying 3 spaces to 2.

I haven't done a PR in a bit so this is a warm up. I have a little list of things tiny little things I wanted to do, its like the sandbag change morrow did forever ago

Explain why it's good for the game

Metal rods and plasteel rods come from metal and plasteel sheets respectively. These rods are a fraction of the size of said sheet, yet they occupy the same space. Although people usually don't carry rods, it didn't seem intuitive to me for them to take up so much space - its like smaller versions of tent poles, you can usually fit them in your backpack and they occupy less space than a sock.

There is no incentive to carry rods instead of sheets, because they take up the same space - despite multiple rods coming from one sheet. It just doesn't feel intuitive

Testing Photographs and Procedure

https://cdn.discordapp.com/attachments/1042176396711170119/1221640724911620166/image.png?ex=66135095&is=6600db95&hm=f8fd020781cbc8d68e5acf552ecf485a6cf34a20291289eef06d823b8c103fce&

Changelog

🆑
balance: Metal rods take up less space in an inventory (3 slots to 2)
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Mar 25, 2024
@@ -54,7 +54,7 @@ GLOBAL_LIST_INIT(rod_recipes, list (
singular_name = "plasteel rod"
icon_state = "rods_plasteel"
flags_atom = FPRINT
w_class = SIZE_MEDIUM
w_class = SIZE_SMALL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just remove this entire line, see the detailed explanation on Discord

Suggested change
w_class = SIZE_SMALL

@QuickLode QuickLode closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants