Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acid runner tweaks #6023

Closed
wants to merge 1 commit into from
Closed

Conversation

Red-byte3D
Copy link
Contributor

@Red-byte3D Red-byte3D commented Mar 27, 2024

About the pull request

Makes it so you no longer get passive acid above 400.
Tailstab no longer applies acid.

Explain why it's good for the game

In the midst of nothingburgers, people have started complaining about acid runners. And i wanted to touch it up before anyone else did because half of the people complaining have never touched xenomorph in their life

Why didnt you touch the queen screech + acid bomb combo

Because an acider needed to farm one thousand acid, plus a queen, plus her being off ovi, plus coordination which i think all of that teamwork should be rewarded

Why didnt you make the runner bomb stop if he went into crit

With the amount of IFF, Grenades, and all the other doo hickeys we have its kind of impossible to run at marines without instantly getting into crit, and all that effort being wasted because of that doesnt feel good for the runner.

Why did you make it so you dont get passive acid above 400
So people dont stay afk in hive from the start to instantly bomb the front

Why didnt you make it so the tailstab doesnt apply acid

An attacked abiltiy that already dazes you with a caste that fast shouldnt reward you with an AOE stack ontop of it. personally it wasnt really an issue for me but i can see why it would be to other people

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: Tailstab no longer applies acid
balance: Passive acid gain for the acider strain now caps at 400.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Mar 27, 2024
@Birdtalon
Copy link
Contributor

Birdtalon commented Mar 27, 2024

Acid runner is fine if a manager disagrees with me they can remove this label.

The main complaint I saw of this was acid runners AFKing in hive which it seems like this PR wants to address. I believe it's a complete non issue. An AFK xeno is one not contributing to the game. If they want to just sit and wait for acid, they're doing nothing else.

@Birdtalon Birdtalon added the Do Not Merge If you merge this PR, I will annihilate you label Mar 27, 2024
@@ -83,7 +83,10 @@
modify_acid(acid_slash_regen_standing)

/datum/behavior_delegate/runner_acider/on_life()
modify_acid(acid_passive_regen)
if(acid_amount > 400)
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't tested this; this will break all the code below it because of this early return

@Drulikar
Copy link
Contributor

Drulikar commented Apr 3, 2024

I don't think this change is necessary. It also makes the corrosive_acid ability that much more egregiously bad to use and the limit on passive regen is poorly communicated to the player (they'd only tell if they kept a close eye on their status panel and notice it doesn't grow most of the time).

@Drulikar Drulikar closed this Apr 3, 2024
@Red-byte3D Red-byte3D deleted the acidrunner branch April 19, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Do Not Merge If you merge this PR, I will annihilate you
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants