Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'movable_pre_move overridden' runtime fix #6024

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

SabreML
Copy link
Member

@SabreML SabreML commented Mar 27, 2024

About the pull request

Fixes this runtime error:

runtime error: movable_pre_move overridden. Use override = TRUE to suppress this warning
 - proc name: stack trace (/proc/stack_trace)
 -   source file: unsorted.dm,1834
 -   usr: Sean Agg (/mob/living/carbon/human)
 -   src: null
 -   usr.loc: the floor (45,79,2) (/turf/open/floor/almayer)
 -   call stack:
 - stack trace("movable_pre_move overridden. U...")
 - the USCM technician welderpack (/obj/item/storage/backpack/marine/engineerpack): RegisterSignal(Sean Agg (/mob/living/carbon/human), "movable_pre_move", /obj/item/storage/proc/storage... (/obj/item/storage/proc/storage_close), 0)
 - the USCM technician welderpack (/obj/item/storage/backpack/marine/engineerpack): is accessible by(Sean Agg (/mob/living/carbon/human))
 - the USCM technician welderpack (/obj/item/storage/backpack/marine/engineerpack): open(Sean Agg (/mob/living/carbon/human))
 - the USCM technician welderpack (/obj/item/storage/backpack/marine/engineerpack): handle mmb open(Sean Agg (/mob/living/carbon/human))
 - the USCM technician welderpack (/obj/item/storage/backpack/marine/engineerpack): clicked(Sean Agg (/mob/living/carbon/human), /list (/list), null, "icon-x=18;icon-y=19;middle=1;b...")
 - Sean Agg (/mob/living/carbon/human): do click(the USCM technician welderpack (/obj/item/storage/backpack/marine/engineerpack), null, "icon-x=18;icon-y=19;middle=1;b...")
 - SabreML (/client): Click(the USCM technician welderpack (/obj/item/storage/backpack/marine/engineerpack), null, "mapwindow.map", "icon-x=18;icon-y=19;middle=1;b...")

This happened when a player tried to open their equipped backpack while it's already open.

Explain why it's good for the game

One less error!

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Fixed a runtime error caused when trying to open an already opened backpack.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Mar 27, 2024
@harryob harryob added this pull request to the merge queue Mar 31, 2024
Merged via the queue into cmss13-devs:master with commit 0adaad6 Mar 31, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants