Fixes a few runtimes from HUD cycling #6025
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes a few runtimes from the 'Cycle Helmet HUD' keybind.
Specifically:
Caused if the player was wearing a hat which wasn't a
/obj/item/clothing/head/helmet/marine
subtype.(In this case a beret)
Caused if the player wasn't wearing a hat at all.
Caused if the player was wearing a
/obj/item/clothing/head/helmet/marine
subtype, but it didn't have a HUD action.(In this case the reporter helmet)
I should note that while this is mostly adding extra checks, I did remove the
?
fromhuman_user?.head
check. As far as I know it isn't possible for a client not to have an attachedmob
, and/datum/keybinding/human/can_use()
covers that either way.Explain why it's good for the game
Three bugfixes for the price of one!
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
fix: Fixed a few runtime errors caused by the 'Cycle Helmet HUD' keybind.
/:cl: