Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Marine Minor (Hive collapse) #6028

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

SabreML
Copy link
Member

@SabreML SabreML commented Mar 27, 2024

About the pull request

Fixes a runtime in /datum/game_mode/colonialmarines/check_queen_status() which was stopping the 'Marine Minor' round result (Hive collapse) from being set. (Added by a tiny mistake in #5442)

runtime error: type mismatch: cannot compare /list (/list) to 3
 - proc name: check queen status (/datum/game_mode/colonialmarines/check_queen_status)
 -   source file: code/game/gamemodes/colonialmarines/colonialmarines.dm,335
 -   usr: null
 -   src: Distress Signal (/datum/game_mode/colonialmarines)
 -   call stack:
 - Distress Signal (/datum/game_mode/colonialmarines): check queen status("xeno_hive_normal")

The totalXenos list itself was being compared to the number instead of the list's length, which aborted the proc before round_finished could be set.
I've gone through all of this year's game logs just to double check, and there hasn't been a 'Marine Minor Victory' since the 24th of January.

Explain why it's good for the game

Marines get a slightly worse victory condition again. (woo!)

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Fixed a runtime error preventing a 'Marine Minor' (Hive collapse) roundend state.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Mar 27, 2024
@harryob harryob added this pull request to the merge queue Mar 31, 2024
Merged via the queue into cmss13-devs:master with commit dd4e0ae Mar 31, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants