Fixes Marine Minor (Hive collapse) #6028
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes a runtime in
/datum/game_mode/colonialmarines/check_queen_status()
which was stopping the 'Marine Minor' round result (Hive collapse) from being set. (Added by a tiny mistake in #5442)The
totalXenos
list itself was being compared to the number instead of the list's length, which aborted the proc beforeround_finished
could be set.I've gone through all of this year's game logs just to double check, and there hasn't been a 'Marine Minor Victory' since the 24th of January.
Explain why it's good for the game
Marines get a slightly worse victory condition again. (woo!)
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
fix: Fixed a runtime error preventing a 'Marine Minor' (Hive collapse) roundend state.
/:cl: