Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metal rods take up less space (From 3 to 2) #6032

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

QuickLode
Copy link
Contributor

About the pull request

This PR changes metal rods and plasteel rods from occupying 3 spaces to 2.

I haven't done a PR in a bit so this is a warm up. I have a little list of things tiny little things I wanted to do, its like the sandbag change morrow did forever ago

Thx Vicarov for some code cleanup

Explain why it's good for the game

Metal rods and plasteel rods come from metal and plasteel sheets respectively. These rods are a fraction of the size of said sheet, yet they occupy the same space. Although people usually don't carry rods, it didn't seem intuitive to me for them to take up so much space - its like smaller versions of tent poles, you can usually fit them in your backpack and they occupy less space than a sock.

There is no incentive to carry rods instead of sheets, because they take up the same space - despite multiple rods coming from one sheet. It just doesn't feel intuitive

Testing Photographs and Procedure

https://cdn.discordapp.com/attachments/1042176396711170119/1221640724911620166/image.png?ex=66135095&is=6600db95&hm=f8fd020781cbc8d68e5acf552ecf485a6cf34a20291289eef06d823b8c103fce&

Changelog

🆑
balance: Metal rods take up less space in an inventory (3 slots to 2)
code: removes some redundant code on plasteel rods
/:cl:

@github-actions github-actions bot added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer labels Mar 27, 2024
Copy link
Contributor

github-actions bot commented Apr 4, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 4, 2024
Copy link
Member

@SabreML SabreML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@SabreML SabreML removed the Stale beg a maintainer to review your PR label Apr 5, 2024
@SabreML SabreML added this pull request to the merge queue Apr 5, 2024
Merged via the queue into cmss13-devs:master with commit c512b2d Apr 5, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants