Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes helmet squad sprite after removing helmet #6044

Closed
wants to merge 2 commits into from

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Mar 29, 2024

About the pull request

should fix #6041 and PROPABLY fix #5912 too, they are the same with diferent method of removing the helmet , shuggest how it should be done right, layering code is... weard

Explain why it's good for the game

bugfix

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: helmet squad stripe remaining after helmet removal
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Mar 29, 2024
@harryob harryob changed the title should fix #6041 removes helmet squad sprite after removing helmet Mar 31, 2024
@harryob
Copy link
Member

harryob commented Mar 31, 2024

your pr title ends up being the commit title that is added to the repo, please make it accurate to the changes being made

@cuberound cuberound changed the title removes helmet squad sprite after removing helmet fixes helmet squadsprite not being removed Apr 1, 2024
@cuberound cuberound changed the title fixes helmet squadsprite not being removed removes helmet squad sprite after removing helmet Apr 1, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 13, 2024
@harryob harryob removed the Stale beg a maintainer to review your PR label Apr 13, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just has the opposite problem where you just won't have a squad stripe when you should:

image

@Drulikar Drulikar marked this pull request as draft April 20, 2024 03:44
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 28, 2024
@github-actions github-actions bot closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Stale beg a maintainer to review your PR
Projects
None yet
4 participants