Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebalances OT rockets to be more incendiary rather than explosive #6045

Merged
merged 13 commits into from
Apr 13, 2024

Conversation

iloveloopers
Copy link
Contributor

@iloveloopers iloveloopers commented Mar 29, 2024

About the pull request

OT rockets explosion power and falloff are now 240 power and 90 falloff
max container volume increased to 210 units (1 beaker, 1 bottle, 1 vial)
max fire intensity increased to 40 (same as blueflame)
max fire duration increased to 48 (max firestacks, blueflame is 40)
OT rockets can no longer make a star shaped fire
max range increased to 7 tiles
these changes will need to be edited in on the wiki
this should probably be test merged and numbers tweaked

Explain why it's good for the game

OT rockets one shotting tier 3s is unfun for the receiving xeno, this PR alleviates that by reducing the maximum explosive power to that of the OT M15 grenade.
To counterbalance, maximum fire intensity and fire duration has been increased to allow for more creativity in mixes, increased max range of the rocket so the user doesn't get hit by his own flames and the fire can no longer be a star shape so that it can be effective.
You cannot max both incendiary and explosive parts without the help of custom research chemicals, the OT must make a choice or compromise.
OT rockets will still be a tier 2 (and marine) killer but overrall less powerful than before,

Testing Photographs and Procedure

Screenshots & Videos

normal WP for reference:

2024-03-29.18-31-40.mp4

a max incendiary rocket:

2024-03-29.18-32-44.mp4

Changelog

🆑Tim Harley cookpet
balance: OT rockets explosion power and falloff nerfed to be slightly more explosive than the OT M15 grenade (240 exp, 90 falloff).
balance: OT rockets max container volume increased to 210 units (1 beaker, 1 bottle, 1 vial).
balance: OT rockets max fire intensity increased to 40 and max duration increased to 48.
balance: OT rockets can no longer make a star shaped fire.
balance: OT rockets max range increased to 7 tiles.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Mar 29, 2024
Copy link
Contributor

github-actions bot commented Apr 6, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 6, 2024
code/game/objects/items/explosives/explosive.dm Outdated Show resolved Hide resolved
code/game/objects/items/explosives/explosive.dm Outdated Show resolved Hide resolved
code/game/objects/items/explosives/warhead.dm Outdated Show resolved Hide resolved
code/modules/reagents/Chemistry-Holder.dm Outdated Show resolved Hide resolved
code/modules/reagents/Chemistry-Holder.dm Outdated Show resolved Hide resolved
code/game/objects/items/explosives/warhead.dm Outdated Show resolved Hide resolved
code/game/objects/items/explosives/warhead.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft April 6, 2024 06:14
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Apr 6, 2024
@iloveloopers iloveloopers marked this pull request as ready for review April 6, 2024 15:52
@Drulikar Drulikar added Testmerge Candidate we'll test this while you're asleep and the server has 10 players Needs Testing Need to test it on the guinea pigs (production server) labels Apr 7, 2024
cm13-github added a commit that referenced this pull request Apr 7, 2024
cm13-github added a commit that referenced this pull request Apr 7, 2024
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Apr 13, 2024
@Drulikar Drulikar added this pull request to the merge queue Apr 13, 2024
Merged via the queue into cmss13-devs:master with commit 460a747 Apr 13, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Apr 13, 2024
@iloveloopers iloveloopers deleted the OT-ROCKET-REBALANCE branch May 7, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Needs Testing Need to test it on the guinea pigs (production server) Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants