Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OT grenades will now have their timer properly reduced when fired from grenade launchers #6048

Closed
wants to merge 2 commits into from

Conversation

iloveloopers
Copy link
Contributor

@iloveloopers iloveloopers commented Mar 30, 2024

About the pull request

OT nades will now have their timer reduced when launched from grenade launchers
this is a bugfix but also a big balance change

Explain why it's good for the game

underused M40 grenade buff
OT can now actually make stuff for grenadier
bug fix technically

Testing Photographs and Procedure

2024-03-30.02-19-41.mp4
2024-03-30.02-20-20.mp4

Changelog

🆑
balance: OT grenades will now have their detonation timer properly reduced when fired from grenade launchers
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Mar 30, 2024
@iloveloopers
Copy link
Contributor Author

please don't make me fix the 1 letter vars its not my code

@iloveloopers
Copy link
Contributor Author

I have a much simpler idea

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try these - or... I guess we'll see the simpler idea I guess.

Comment on lines +2882 to +2886
timer.time = 15
else
if(istimer(G.detonator.a_right))
var/obj/item/device/assembly/timer/timer = G.detonator.a_right
timer.time = 15
Copy link
Contributor

@Drulikar Drulikar Mar 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
timer.time = 15
else
if(istimer(G.detonator.a_right))
var/obj/item/device/assembly/timer/timer = G.detonator.a_right
timer.time = 15
timer.time -= 1.5 SECONDS
if(istimer(G.detonator.a_right))
var/obj/item/device/assembly/timer/timer = G.detonator.a_right
timer.time -= 1.5 SECONDS

Comment on lines +204 to +208
timer.time = 10
else
if(istimer(fired.detonator.a_right))
var/obj/item/device/assembly/timer/timer = fired.detonator.a_right
timer.time = 10
Copy link
Contributor

@Drulikar Drulikar Mar 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
timer.time = 10
else
if(istimer(fired.detonator.a_right))
var/obj/item/device/assembly/timer/timer = fired.detonator.a_right
timer.time = 10
timer.time -= 1 SECONDS
if(istimer(fired.detonator.a_right))
var/obj/item/device/assembly/timer/timer = fired.detonator.a_right
timer.time -= 1 SECONDS

@iloveloopers iloveloopers deleted the OT-NADE-GL-FIX branch March 30, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants