Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes acid spray extinguish more consistent #6053

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

Git-Nivrak
Copy link
Contributor

@Git-Nivrak Git-Nivrak commented Mar 30, 2024

About the pull request

Acid spray used to only extinguish you if you were on the same tile when it is initialized rather than when crossing it as well, this PR makes it so it extinguishes you when crossing it as well.

Explain why it's good for the game

Extremely weird and unintuitive when you walk over 3 tiles of acid spray and don't get extinguished.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: Acid sprays will now extinguish fire from other xenomorphs more consistently
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Mar 30, 2024
@gitbirb
Copy link

gitbirb commented Mar 30, 2024

I think this will fix #3412

@Red-byte3D
Copy link
Contributor

this is also a balance change

Copy link
Member

@SabreML SabreML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also a balance change

I'll give this a day or so once it's approved in case anyone else wants to weigh in, but I would personally say it's more on the QOL side of things than balance. At most, a burning xeno would have 1 second to step into the acid path before it dissipates.

code/game/objects/effects/aliens.dm Outdated Show resolved Hide resolved
@SabreML SabreML added this pull request to the merge queue Apr 4, 2024
Merged via the queue into cmss13-devs:master with commit 149d4a0 Apr 4, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acid Spray doesn't extinguish the target consistently. (unless they are standing still)
4 participants