Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Makes Xenomorphs tackling/disarming people show in attack logs.
Additionally, this also changes
mob/living/carbon/xenomorph/M
tomob/living/carbon/xenomorph/attacking_xeno
in the proc's parameters, and merges two behavior_delegate checks that were right next to each other.It's being logged with
log_attack()
rather than themsg_admin_attack()
used by human disarming since a xeno tackling someone is a normal part of the game loop, and not something that could potentially need admin attention.Explain why it's good for the game
"Normal part of the game" or not, this is the sort of thing which should be in attack logs.
Testing Photographs and Procedure
Screenshots & Videos
Xenomorph combat logs:
Human combat logs:
attack.log
:Changelog
🆑
admin: Added attack logging for Xeno tackling.
/:cl: