Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attack logs for xeno tackling #6061

Merged
merged 5 commits into from
Apr 6, 2024
Merged

Conversation

SabreML
Copy link
Member

@SabreML SabreML commented Mar 31, 2024

About the pull request

Makes Xenomorphs tackling/disarming people show in attack logs.
Additionally, this also changes mob/living/carbon/xenomorph/M to mob/living/carbon/xenomorph/attacking_xeno in the proc's parameters, and merges two behavior_delegate checks that were right next to each other.

It's being logged with log_attack() rather than the msg_admin_attack() used by human disarming since a xeno tackling someone is a normal part of the game loop, and not something that could potentially need admin attention.

Explain why it's good for the game

"Normal part of the game" or not, this is the sort of thing which should be in attack logs.

Testing Photographs and Procedure

Screenshots & Videos

Xenomorph combat logs:
dreamseeker_egsPasjsdj

Human combat logs:
dreamseeker_UZFD8dNiYt

attack.log:

[2024-03-31 21:48:27.610] ATTACK: sabreml/(Young Drone (XX-653)) unsuccessfully tackled @SabreML/(Sean Agg) in Open grounds (event P) (45,82,2).
[2024-03-31 21:48:28.684] ATTACK: sabreml/(Young Drone (XX-653)) unsuccessfully tackled @SabreML/(Sean Agg) in Open grounds (event P) (45,82,2).
[2024-03-31 21:48:29.700] ATTACK: sabreml/(Young Drone (XX-653)) successfully tackled @SabreML/(Sean Agg) in Open grounds (event P) (45,82,2).

Changelog

🆑
admin: Added attack logging for Xeno tackling.
/:cl:

@github-actions github-actions bot added the Admin Make things harder for admins label Mar 31, 2024
@harryob harryob added this pull request to the merge queue Apr 6, 2024
Merged via the queue into cmss13-devs:master with commit eb5c82c Apr 6, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Make things harder for admins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants