Toggle ghost now leaves the users mob visible

[vero5123]

About the pull request

Fixes #5894

Explain why it's good for the game

bug fix

Changelog

🆑
fix: toggling ghost vision now keeps the user's mob visible.
/:cl:

[fira]

I'm not sure removing ghost plane handling is much of a fix

[vero5123]

I'm not sure removing ghost plane handling is much of a fix

I mean, it fixes it. I don't think it's too hacky. Do we really have to mess with the alpha of the ghost plane lighting and set it to 0?

[Blundir]

This pr isn't exactly optimal feature-wise, seeing no ghosts at all is good for making screenshots both locally and on server itself, this pr just completely removes the ability, without providing alternatives.

[vero5123]

This pr isn't exactly optimal feature-wise, seeing no ghosts at all is good for making screenshots both locally and on server itself, this pr just completely removes the ability, without providing alternatives.

No it doesn't, you toggle ghost visibility, which hides all mobs but yourself and then you can toggle self visibility which hides your mob from your pov and others.

[PowerfulBacon]

Are there things on the ghost layer that would be inadvertantly hidden by changing the see_invisible flags?

[vero5123]

Are there things on the ghost layer that would be inadvertantly hidden by changing the see_invisible flags?

Afik, No. Just the ghosts. It's just changing the visibility from 60 to 59. There is nothing in between.