Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes notifications emitting light #6088

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Fixes notifications emitting light #6088

merged 2 commits into from
Apr 8, 2024

Conversation

vero5123
Copy link
Contributor

@vero5123 vero5123 commented Apr 5, 2024

About the pull request

Fixes #5985, albeit there might be a better approach.

Explain why it's good for the game

bug fix, tested it with the steps listed in the issue. Worked as far as I could tell.

Changelog

🆑
fix: Notifications should no longer emit light.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Apr 5, 2024
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't do this - just cut the underlays of the alert_overlay

Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@harryob harryob marked this pull request as draft April 6, 2024 10:51
@vero5123
Copy link
Contributor Author

vero5123 commented Apr 6, 2024

hehe, yeah.

@vero5123 vero5123 marked this pull request as ready for review April 6, 2024 20:30
@harryob harryob added this pull request to the merge queue Apr 8, 2024
Merged via the queue into cmss13-devs:master with commit 39fc6f7 Apr 8, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications emit light
2 participants