Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCC Buff/medical knowledge needed #6092

Closed
wants to merge 8 commits into from
Closed

DCC Buff/medical knowledge needed #6092

wants to merge 8 commits into from

Conversation

HumiliatedGoblin
Copy link
Contributor

@HumiliatedGoblin HumiliatedGoblin commented Apr 6, 2024

About the pull request

This PR adds in a medical hour requirement for dropship crew chiefs, as they have medical training and should are required to be knowledgeable on medical.
It also adds in the ability for dropship crew to fix their doors with a multitool. Instead of the usual five seconds for engineering trained personnel, dropship crew take eight seconds.
Finally, a tip is added,

"As a Queen, you can unbolt dropship doors open by clicking on them, even if they are unlocked. Pilots, Dropship crew chiefs, Engineers and Synths can repair these doors with a multitool."

And two others are modified.

Explain why it's good for the game

Since Dropship Crew Chiefs have surgery knowledge, they must have a buffer to make sure that people who play Dropship Crew Chief are knowledgeable on medicine. This is the same for medics and doctors.

Next, it seems kinda stupid that Dropship crew aren't able to fix the own doors to their own dropship, and adds to the stigma that transport pilots and DCC's are un-fun to play, ignored and useless. By making it so they can actually repair their own dropships, they can bring a little more usefulness to rounds.

Finally, a tip is added to accommodate this PR, as I'm pretty sure no one even knew you CAN repair queen destroyed doors. I'd like to add a description to broken doors, but I'm not sure if that's possible with doorcode.

Testing Photographs and Procedure

Screenshots & Videos

i tested it and it worked but my medal didnt work so uh take my word for it

Changelog

🆑
add: Adds 1 medical hour for DCC
add: Adds and modifies some tips of the rounds.
balance: Dropship crew chiefs and pilots can now repair dropship doors
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Apr 6, 2024
Comment on lines +266 to +280
if(!skillcheck(user, SKILL_PILOT, SKILL_PILOT_TRAINED))
to_chat(user, SPAN_WARNING("You don't seem to understand how to restore a remote connection to [src]."))
return
if(user.action_busy)
return
else
to_chat(user, SPAN_WARNING("You begin to restore the remote connection to [src]."))
if(!do_after(user, 8 SECONDS, INTERRUPT_ALL, BUSY_ICON_BUILD))
to_chat(user, SPAN_WARNING("You fail to restore a remote connection to [src]."))
return
unlock(TRUE)
close(FALSE)
control.status = SHUTTLE_DOOR_UNLOCKED
to_chat(user, SPAN_WARNING("You successfully restored the remote connection to [src]."))
return
Copy link
Contributor

@ihatethisengine ihatethisengine Apr 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your intends are wrong and code is working ONLY if you don't have engineering skill

Suggested change
if(!skillcheck(user, SKILL_PILOT, SKILL_PILOT_TRAINED))
to_chat(user, SPAN_WARNING("You don't seem to understand how to restore a remote connection to [src]."))
return
if(user.action_busy)
return
else
to_chat(user, SPAN_WARNING("You begin to restore the remote connection to [src]."))
if(!do_after(user, 8 SECONDS, INTERRUPT_ALL, BUSY_ICON_BUILD))
to_chat(user, SPAN_WARNING("You fail to restore a remote connection to [src]."))
return
unlock(TRUE)
close(FALSE)
control.status = SHUTTLE_DOOR_UNLOCKED
to_chat(user, SPAN_WARNING("You successfully restored the remote connection to [src]."))
return
if(!skillcheck(user, SKILL_ENGINEER, SKILL_ENGINEER_ENGI) && !skillcheck(user, SKILL_PILOT, SKILL_PILOT_TRAINED))
to_chat(user, SPAN_WARNING("You don't seem to understand how to restore a remote connection to [src]."))
return
if(user.action_busy)
return
else
to_chat(user, SPAN_WARNING("You begin to restore the remote connection to [src]."))
if(!do_after(user, (skillcheck(user, SKILL_ENGINEER, SKILL_ENGINEER_ENGI) ? 5 SECONDS : 8 SECONDS), INTERRUPT_ALL, BUSY_ICON_BUILD))
to_chat(user, SPAN_WARNING("You fail to restore a remote connection to [src]."))
return
unlock(TRUE)
close(FALSE)
control.status = SHUTTLE_DOOR_UNLOCKED
to_chat(user, SPAN_WARNING("You successfully restored the remote connection to [src]."))
return

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait you just duplicated the code? Hold on

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to rework it on another repo since i accidentally did it all on master instead of a branch. i didn't see another way to do the skill checks since you cant have more then 2 skills in a skill check (according to checks anyways)

github-merge-queue bot pushed a commit that referenced this pull request Apr 7, 2024
# About the pull request

(cleaned up ver of #6092 + using better code from ihatethisengine)
This PR adds in a medical hour requirement for dropship crew chiefs, as
they have medical training and should are required to be knowledgeable
on medical.
It also adds in the ability for dropship crew to fix their doors with a
multitool. Instead of the usual five seconds for engineering trained
personnel, dropship crew take eight seconds.
Finally, a tip is added,

> "The Queen can unbolt and break dropship doors by prying them open,
even if they are unlocked. Pilots, Dropship Crew Chiefs, Engineers and
Synths can repair these doors with a multitool."

# Explain why it's good for the game

Since Dropship Crew Chiefs have surgery knowledge, they must have a
buffer to make sure that people who play Dropship Crew Chief are
knowledgeable on medicine. This is the same for medics and doctors.

Next, it seems kinda stupid that Dropship crew aren't able to fix the
own doors to their own dropship, and adds to the stigma that transport
pilots and DCC's are un-fun to play, ignored and useless. By making it
so they can actually repair their own dropships, they can bring a little
more usefulness to rounds.

Finally, a tip is added to accommodate this PR, as I'm pretty sure no
one even knew you CAN repair queen destroyed doors. I'd like to add a
description to broken doors, but I'm not sure if that's possible with
doorcode (im not very smart).

# Testing Photographs and Procedure

<details>
<summary>Screenshots & Videos</summary>

it works i tested it i think

</details>

# Changelog

:cl:
add: Adds a one hour medical timelock for DCC's
add: Adds a tip of the round to accommodate for this PR and #5808
balance: DCCs and Pilots can now fix queen broken dropship doors
/:cl:

---------

Co-authored-by: Drathek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants