Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deconstructing walls without repairing them #6094

Merged
merged 5 commits into from
May 1, 2024

Conversation

HumiliatedGoblin
Copy link
Contributor

@HumiliatedGoblin HumiliatedGoblin commented Apr 6, 2024

About the pull request

You now need to have disarm or above to slice through walls, and help intent to repair walls.

Explain why it's good for the game

Comtechs now don't need to spend 30 seconds repairing a wall, waste like 5 units of welding fuel only to deconstruct it. Now you can have choice in what you do! :D

Testing Photographs and Procedure

Screenshots & Videos

it works trust

Changelog

🆑
qol: Now needs help intent to repair walls
qol: Now needs disarm, grab and harm intent to deconstruct walls
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Apr 6, 2024
@HumiliatedGoblin
Copy link
Contributor Author

OOPS WRONG BUTTON SORRY VRO

@ihatethisengine
Copy link
Contributor

WHAT THE HECKKKK

Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might need some text adding to the examine strings to make this more obvious beyond a changelog entry - thoughts?

@harryob harryob marked this pull request as draft April 13, 2024 10:04
@HumiliatedGoblin
Copy link
Contributor Author

we might need some text adding to the examine strings to make this more obvious beyond a changelog entry - thoughts?

Do you think it would be better to have info on the wall, or on the blowtorch? Or both?
My idea is to just put it underneath the weld_state string, but maybe you'd have a better idea

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 22, 2024
@HumiliatedGoblin HumiliatedGoblin marked this pull request as ready for review April 27, 2024 07:58
@HumiliatedGoblin
Copy link
Contributor Author

@harryob HARRY PLEASE

@Drulikar Drulikar added this pull request to the merge queue May 1, 2024
Merged via the queue into cmss13-devs:master with commit 0f67b3a May 1, 2024
26 checks passed
cm13-github added a commit that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants